Skip to content

Bump Lemonade: 1bit-MONSTER/lemonade c5ba797132a4 - #462

Merged
bong-water-water-bong merged 1 commit into
mainfrom
bump-lemonade/c5ba797132a4
Oct 20, 2026
Merged

bong-water-water-bong merged 1 commit into
mainfrom
bump-lemonade/c5ba797132a4

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

Moves third_party/lemonade from 1cb46be46954 to the fork's main c5ba797132a4.

Fork commits (last 30):

CI here has no GPU. Before merging, on Strix Halo:
scripts/build-lemonade.sh ~/.cache/lemonade-pin, then Lemonade's LLM suite through the onebit recipe (docs/lemonade.md).

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

14 - Partially compliant

Compliant requirements:

  • Pin ZINC at upstream main c50b4add
  • Build ZINC with scripts/build-zinc.sh using Zig 0.15.2
  • Verified ZINC builds and runs on Strix Halo with Vulkan and ROCm
  • Verified ZINC CUDA backend on RTX 5090 with Qwen3.5-9B
  • Docs updated to cover ZINC pin, build, and verified results
  • docs/PORTING.md updated with step 6
  • Fork commits not carried
  • No Lemonade backend spawning zinc implemented yet

Non-compliant requirements:

  • None

Requires further human verification:

  • Verification of ZINC CUDA backend on RTX 5090 (already mentioned in PR description)
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Subproject Update

The PR updates the third_party/lemonade subproject to a new commit. While this is a straightforward update, it's important to confirm that the new commit (c5ba797132a432d1201a21996c435bbc52e4409e) is compatible with the rest of the system and doesn't introduce any regressions or breaking changes.

Subproject commit c5ba797132a432d1201a21996c435bbc52e4409e

@bong-water-water-bong
bong-water-water-bong merged commit 926ba6a into main Oct 20, 2026
8 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the bump-lemonade/c5ba797132a4 branch October 20, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant