[bong-water-water-bong]

Second hardware boot of the appliance (candidate 8, 26 Oct, Secure Boot on): the menu drew on tty1 and waited for a key; the owner could not type. Over ssh: /dev/input held only mice, dmesg listed no USB keyboard, lsmod showed hid (pulled in by amd_sfh) but no usbhid or hid_generic, and the initramfs's drivers/hid/ directory had only hid.ko.xz and the amd-sfh driver. In this kernel CONFIG_USB_HID=m and CONFIG_HID_GENERIC=m, and the image's module list never named them. The KVM's keyboard and any USB keyboard are HID devices, so no keystroke could reach the console. On candidate 5 the same gap sat behind the kernel-message flood that #582 removed.

os/mini/mkimage.sh: usbhid hid_generic evdev join the module list (their dependencies come along the way the list already resolves them with modprobe --show-depends). os/mini/init.sh: the same three load with the other USB drivers before the console and the menu start.

The gate cannot prove a keyboard (it drives the serial line); the proof is the next stick.

🤖 Generated with Claude Code

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 582 - Partially compliant Compliant requirements: The console shell now has a visible prompt '1bit-os:\w # ' which matches the gate's expected pattern Kernel messages no longer overwrite the shell prompt due to proper loglevel configuration USB keyboard support is enabled with the addition of usbhid, hid_generic, and evdev modules The init script now loads usbhid, hid_generic, and evdev before starting the console and menu Non-compliant requirements: None Requires further human verification: None

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Module Dependencies The addition of usbhid, hid_generic, and evdev modules in mkimage.sh may introduce dependency issues if the module resolution logic doesn't properly account for all required dependencies. While the code uses modprobe --show-depends to resolve dependencies, there's a potential for missing transitive dependencies that could cause runtime failures. mods="nvme ahci amd_pmf amdgpu amdxdna r8169 realtek mt7925e xhci_pci usb_storage uas sd_mod vfat ext4 nls_iso8859_1 nls_cp437 nls_ascii virtio_net virtio_blk thunderbolt thunderbolt_net typec ucsi_acpi typec_displayport usbhid hid_generic evdev" Driver Loading Order The order of driver loading in init.sh has been changed to include USB HID drivers. While this is necessary for keyboard support, it's important to ensure that this change doesn't negatively impact the boot sequence or cause conflicts with other drivers that were previously loaded in a specific order. for m in realtek r8169 mt7925e virtio_net xhci_pci usb_storage uas sd_mod nvme ahci vfat nls_cp437 nls_iso8859_1 nls_ascii ext4 phy-generic typec typec_ucsi ucsi_acpi typec_displayport thunderbolt usbhid hid_generic evdev; do modprobe -q "$m"; done