Skip to content

PR-Agent: local coding model on the strixhalo runner - #61

Merged
bong-water-water-bong merged 3 commits into
mainfrom
pr-agent
Sep 25, 2026
Merged

bong-water-water-bong merged 3 commits into
mainfrom
pr-agent

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

Adds PR-Agent (0.43.0) to the engine repo.

  • Model: Qwen3-Coder-30B-A3B-Instruct UD-Q5_K_XL, served by 1bit serve on Vulkan, 64K context. It runs on strixhalo as the coder-llm user service at 127.0.0.1:8090.
  • Runner: self-hosted strixhalo-engine (label pr-agent). No code leaves the box, and there is no API key or Docs7 quota.
  • Opened or updated PRs get a review. Owners, members and collaborators can comment /review, /describe, /improve or /ask <question>.
  • .pr_agent.toml carries engine-specific review instructions: correctness on NPU/HRX/Vulkan, C++ ownership, measured claims only, the Apache notice, and docs updated in the same PR.

This PR itself is the first test run.

🤖 Generated with Claude Code

Qwen3-Coder-30B-A3B UD-Q5_K_XL served by 1bit serve (Vulkan) at 127.0.0.1:8090,
job on the self-hosted pr-agent runner; no cloud API or key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@context7

context7 Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Docs7 for 1bit-monster/engine

Result Status Action
Deployment ➖ Not used —
Content review ➖ Did not run. This site has no agent runs available this month. Wait for the monthly reset or check your Docs7 plan. —

Commit 4dca26c

@github-actions

Copy link
Copy Markdown

Preparing review...

…only)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 4dca26c)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential Timeout Issue in Model Readiness Check

The model readiness check in the workflow uses a loop with a 10-second sleep between attempts. If the model takes longer than 300 seconds (30 attempts * 10 seconds) to become ready, the workflow will fail. This could be problematic if the model takes longer to load, especially in a resource-constrained environment. Consider increasing the timeout or making it configurable.

ready=0
for i in $(seq 1 30); do
  if curl -sf --max-time 60 http://127.0.0.1:8090/v1/chat/completions -H 'Content-Type: application/json' \
       -d '{"model":"qwen3-coder","messages":[{"role":"user","content":"ok"}],"max_tokens":1}' > /dev/null; then
    ready=1; break
  fi
  sleep 10
done
[ "$ready" = 1 ] || { echo "::error::the local model (coder-llm on :8090) does not answer"; exit 1; }
Possible Command Injection Vulnerability

The command parsing logic in the workflow directly uses printf '%s' "$COMMENT_BODY" without sanitizing the input. If a malicious user crafts a comment with a specially crafted payload, it could potentially lead to command injection. While the workflow uses sed and case to parse commands, it's still risky to trust user input directly. Consider adding input validation or sanitization.

cmd=$(printf '%s' "$COMMENT_BODY" | sed -E 's/^[[:space:]]*\/?//; s/[[:space:]].*//' | tr '[:upper:]' '[:lower:]')
case "$cmd" in
  review)   run review ;;
  describe) run describe ;;
  improve)  run improve ;;
  ask)      run ask "$(printf '%s' "$COMMENT_BODY" | sed -E 's/^[[:space:]]*\/?ask[[:space:]]*//')" ;;
  *)        echo "not a PR-Agent command: $cmd" ;;
esac

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 4dca26c

@bong-water-water-bong
bong-water-water-bong merged commit a97a479 into main Sep 25, 2026
3 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the pr-agent branch September 25, 2026 08:39
bong-water-water-bong pushed a commit that referenced this pull request Oct 2, 2026
… (review)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong added a commit that referenced this pull request Oct 2, 2026
…mat SwiGLU, Hadamard Q4_0 (#278)

* Pin llama.cpp bd5b297: HRX remainder prefill, 32K+ prompts, mixed-format SwiGLU, Hadamard Q4_0

llama.cpp fork commits since 6e42b51 (figures from each PR, Qwen3.8-27B on HRX0, balanced mode):
- #61: q8_1 x4 prefill takes the 256-aligned head of a Q5_K/IQ4_XS remainder chunk.
  UD-Q4_K_XL pp400 67.4 -> 103.4, pp1862 172.1 -> 234.6 tok/s; KLD vs 6e42b51 0.00215,
  same top token 97.19%; MUL_MAT HRX0 287/287.
- #59: V stays row-major past copy_transpose_f16's 32768-row range. pp512 @ d32768 failed
  before, 227.4 tok/s now; a 34,816-token wikitext chunk gives PPL 6.2150.
- #60: K-quant SwiGLU decode stages separate gate/up codebooks. UD-IQ2_S tg128 3.12 -> 8.32;
  UD-Q4_K_XL unchanged; KLD 0.00013; test-backend-ops HRX0 996/996.
- #58: llama loads onebit.hadamard_q4_0 files through llama-hadamard (needed by #277).
  Q4_0-H32 vs BF16: PPL 6.021, KLD 0.0292, same top token 92.5%.

Docs: docs/hrx.md #55 section (remainders now covered for Q5_K/IQ4_XS) and "Our patches".
Registry regenerated (tools/registry_build.py; no mapping changes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs/hrx.md: the #61 figures were measured on 6e42b51 + #61 (a36d547) (review)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant