Repository navigation
Bump Laya: source 0565524a, model 7b928d82 - #835
Conversation
PR Reviewer Guide 🔍(Review updated until commit 7a2b9c1)Here are some key observations to aid the review process:
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 3b82ed140 — the pin is upstream's HEAD, and the content between the two pins is provably not the
router.
What I checked, in order:
- the new pin exists and is current:
0565524a27bcb9821bcd7c42aaf49d925f6f8560isNandhaKishorM/layamain's HEAD
(gh api repos/NandhaKishorM/laya/commits/main), commit "chore(ci): correct the pypi-publish pin comment to v1.14.3",
2026-11-01. The old pin8c42cf351274is "release: 0.4.21". - what actually moved between them, by comparing the two trees (
git/trees/<sha>?recursive=1, 2,533 entries each):
17 entries changed, 0 added, 0 removed —.github/{workflows/*.yml,.github}(nine workflow files),
.gitleaksignore,laya-ts/package.json,laya-ts/package-lock.jsonandpyproject.toml. Not one.pyfile
differs, so the classifier/router code the engine actually drives is byte-identical between the pins. - the only functional line in
pyproject.tomlis a dependency bound,"agno>=1.1.14,<2"→"<4";laya-tsis the
TypeScript client, which the engine does not use. - the model side is unchanged, as the body says:
config/laya.jsonat this head still pins
convaiinnovations/layarevision7b928d828b7b0e022f929d9bd2e44165aa270148, andgit ls-tree 3b82ed140 third_party/layais exactly0565524a27bc. Own diff is that single gitlink line, nothing else.
So the "before merging: scripts/fetch-laya.sh and the Laya tests" line in the body is the belt-and-braces check the
lane can run; what it cannot change is behaviour, because there is no Python or weight difference to change. I did not
run scripts/fetch-laya.sh (it downloads the three checkpoints) — the tree comparison is the stronger statement for a
source-only bump, and the goldens' concern from #699 does not arise here.
CI at this head: build pass 5m29s, pr_agent pass, CodeQL + all four Analyze pass. tprs-ready applied.
|
Persistent review updated to latest commit 32434c0 |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 32434c06a — re-head after the update-branch; the bump itself is unchanged and the pin is still
upstream's HEAD.
git diff --stat <merge-base d04cbf1> 32434c06a -> third_party/laya | 2 +- (1 file, 1 insertion, 1 deletion)
git ls-tree 32434c06a third_party/laya -> 160000 commit 0565524a27bcb9821bcd7c42aaf49d925f6f8560
config/laya.json at this head -> source revision 7b928d828b7b0e022f929d9bd2e44165aa270148 (unchanged)
The verification behind the earlier READY still describes this tree, because the gitlink is the same commit:
0565524a27bc is NandhaKishorM/laya main's HEAD (chore(ci): correct the pypi-publish pin comment to v1.14.3,
2026-11-01), and comparing the two pins' trees (2,533 entries each) gives **17 changed entries, 0 added, 0 removed, and
not one .py file among them — nine .github/workflows/*.yml, .gitleaksignore, laya-ts/package.json,
laya-ts/package-lock.json and pyproject.toml (whose only functional line is "agno>=1.1.14,<2" → "<4"). The router
the engine drives cannot differ between these pins.
CI at this head: build pass 4m59s, CodeQL pass, pr_agent pass. tprs-ready is on; this line is the merge gate for
the head the waiter will squash.
|
Persistent review updated to latest commit 7a2b9c1 |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 7a2b9c121 — re-head after #833 merged: own diff is still the single gitlink line (third_party/laya, 1 insertion 1 deletion) and git ls-tree 7a2b9c121 third_party/laya is still 160000 commit 0565524a27bcb9821bcd7c42aaf49d925f6f8560, which is NandhaKishorM/laya main's HEAD; config/laya.json's source revision is still 7b928d828b7b… and the tree comparison between the two pins stands at 17 changed entries, zero .py files (nine workflow files, .gitleaksignore, laya-ts/package{,-lock}.json, pyproject.toml with agno <2 -> <4). build pass 4m21s at this head, pr_agent pass, CodeQL pass. tprs-ready on — merge gate for this head.
third_party/laya:
8c42cf351274->0565524a27bc(NandhaKishorM/laya main). config/laya.json revision:7b928d828b7b->7b928d828b7b(convaiinnovations/laya).Before merging: scripts/fetch-laya.sh
(verifies every file) and the Laya tests.