Repository navigation
refactor(lib): use real subdir paths in exports - #1077
Merged
Merged
Conversation
Replace 12 flat export aliases in @pagespace/lib with paths that match the actual source layout: - ./secure-compare, ./device-auth-utils, ./broadcast-auth, ./verification-utils → ./auth/* - ./activity-tracker, ./ai-monitoring, ./ai-context-calculator → ./monitoring/* - ./logger-config, ./logger-database, ./logger-browser, ./logger → ./logging/* - ./api-utils → ./utils/api-utils Updates 114 import statements across apps/web, apps/realtime, and apps/processor. Both exports and typesVersions fields in package.json updated in lockstep. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe PR reorganizes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The first pass only caught static `from '...'` imports. vi.mock(), vi.doMock(), await import(), and vitest.config alias maps also contained the old flat paths. Replace all remaining occurrences across apps/web, apps/realtime, and apps/processor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9accee14e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (21)
apps/web/src/app/api/auth/google/__tests__/one-tap.test.ts (1)
101-124:⚠️ Potential issue | 🔴 CriticalPoint the Vitest mock at the same subpath as the import.
The test now imports
trackAuthEventfrom@pagespace/lib/monitoring/activity-tracker, but the mock still registers the old@pagespace/lib/activity-trackerspecifier, so the assertion can hit the real module instead of a spy.🐛 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));Verify remaining stale mocks:
#!/bin/bash rg -n -C2 "vi\.mock\('@pagespace/lib/activity-tracker'|from '@pagespace/lib/monitoring/activity-tracker'" --type=ts🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/google/__tests__/one-tap.test.ts` around lines 101 - 124, The test registers a Vitest mock for the wrong module specifier so the imported trackAuthEvent (imported from '@pagespace/lib/monitoring/activity-tracker') can be the real module; update the vi.mock call to target the same subpath used by the import (replace the existing vi.mock('@pagespace/lib/activity-tracker', ...) with vi.mock('@pagespace/lib/monitoring/activity-tracker', ...) so trackAuthEvent is a spy), then run the provided rg check to find any other stale vi.mock entries.apps/web/src/app/api/pages/[pageId]/export/xlsx/__tests__/route.test.ts (1)
43-58:⚠️ Potential issue | 🟠 MajorUpdate the mock path alongside the import path.
Line 58 imports
trackPageOperationfrom the new monitoring subpath, but Lines 43-45 still mock the old flat subpath. ThetrackPageOperationassertion will not be using this mock.Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackPageOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/pages/`[pageId]/export/xlsx/__tests__/route.test.ts around lines 43 - 58, The test is mocking the old path for trackPageOperation so the imported trackPageOperation used in the test isn't the mock; update the vi.mock call to match the import path by replacing vi.mock('@pagespace/lib/activity-tracker', ...) with vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackPageOperation: vi.fn() })), ensuring the mock exports the same symbol name trackPageOperation so assertions against trackPageOperation in the tests use the mock.apps/web/src/app/api/auth/apple/native/__tests__/route.test.ts (1)
87-121:⚠️ Potential issue | 🟠 MajorUpdate the mock to match the new activity tracker import.
Line 121 imports
@pagespace/lib/monitoring/activity-tracker, but Lines 87-89 still mock the old@pagespace/lib/activity-trackersubpath. This leavestrackAuthEventunmocked for the assertions below.Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/apple/native/__tests__/route.test.ts` around lines 87 - 121, The test's mock targets the old import path so trackAuthEvent (used by POST route tests) isn't being mocked; update the vi.mock call that currently targets '@pagespace/lib/activity-tracker' to mock the new import '@pagespace/lib/monitoring/activity-tracker' and export trackAuthEvent: vi.fn() (matching the imported symbol trackAuthEvent) so assertions referencing trackAuthEvent are properly stubbed.apps/web/src/app/api/auth/passkey/[passkeyId]/__tests__/route.test.ts (1)
29-43:⚠️ Potential issue | 🔴 CriticalCritical:
vi.mockspecifier was not updated to match the new import path.Line 43 now imports
trackAuthEventfrom@pagespace/lib/monitoring/activity-tracker, but thevi.mock(...)on line 29 still points at@pagespace/lib/activity-tracker. The mock is keyed by exact module specifier, so it won't apply — the realtrackAuthEventwill be pulled into both the test and the route under test, andexpect(trackAuthEvent).toHaveBeenCalledWith(...)assertions will fail (or worse, exercise real side effects).Note: the AI summary claims this mock path was updated, but the submitted code shows it was not.
🔧 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/passkey/`[passkeyId]/__tests__/route.test.ts around lines 29 - 43, The mocked module specifier is wrong: update the vi.mock call that currently targets "@pagespace/lib/activity-tracker" to the new import path "@pagespace/lib/monitoring/activity-tracker" so the mock applies to the same module used by the route and tests, ensuring trackAuthEvent is the mocked vi.fn() referenced by imports of trackAuthEvent and preventing real side effects.apps/web/src/app/api/auth/__tests__/mobile-oauth-google-exchange.test.ts (1)
63-113:⚠️ Potential issue | 🔴 CriticalCritical:
vi.mockpath was not updated alongside the import — mock is now inert.Line 113 imports
trackAuthEventfrom@pagespace/lib/monitoring/activity-tracker, but thevi.mock(...)at line 63 still targets the old@pagespace/lib/activity-trackerspecifier. Vitest resolves mocks by exact module specifier, so the realtrackAuthEventwill be imported here (and inside the route module under test), causingexpect(trackAuthEvent).toHaveBeenCalledWith(...)assertions to break and potentially triggering real DB writes during the unit test.🔧 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/__tests__/mobile-oauth-google-exchange.test.ts` around lines 63 - 113, The vi.mock for the activity tracker uses the old specifier and is therefore inert; update the mock call to target the new module specifier '@pagespace/lib/monitoring/activity-tracker' (providing trackAuthEvent: vi.fn()) and ensure this vi.mock appears before the import of trackAuthEvent/route under test so the imported trackAuthEvent is the mocked fn used in assertions.apps/processor/src/__tests__/cors-validation.test.ts (1)
12-23:⚠️ Potential issue | 🔴 CriticalCritical:
vi.mocktarget is stale and won't intercept the new import path.Line 12 still mocks
@pagespace/lib/logger-config, but line 23 (and presumably../utils/cors-validation) now imports from@pagespace/lib/logging/logger-config. Vitest keys mocks by module specifier, so the old-path mock no longer applies:loggerswill be the real module, and theexpect(loggers.processor.warn).toHaveBeenCalledWith(...)assertions will either fail or invoke the real logger.🔧 Proposed fix
-vi.mock('@pagespace/lib/logger-config', () => ({ +vi.mock('@pagespace/lib/logging/logger-config', () => ({ loggers: { processor: { debug: vi.fn(), info: vi.fn(), warn: vi.fn(), error: vi.fn(), }, }, }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/processor/src/__tests__/cors-validation.test.ts` around lines 12 - 23, The test's vi.mock currently targets '@pagespace/lib/logger-config' but the code under test imports from '@pagespace/lib/logging/logger-config', so update the vi.mock call to mock the exact module specifier '@pagespace/lib/logging/logger-config' and keep the same mocked shape (loggers.processor.{debug,info,warn,error}); also ensure the vi.mock is declared before importing the module-under-test or the named import `loggers` so that `expect(loggers.processor.warn).toHaveBeenCalledWith(...)` asserts against the mock.apps/web/src/app/api/auth/google/one-tap/__tests__/route.test.ts (1)
102-104:⚠️ Potential issue | 🔴 CriticalFix the mock path to match the new import path.
The mock at line 102 uses the old path
@pagespace/lib/activity-tracker, but the import at line 133 uses the new path@pagespace/lib/monitoring/activity-tracker. This mismatch will cause the mock to fail to intercept the import, leading to test failures or unexpected behavior.🐛 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/google/one-tap/__tests__/route.test.ts` around lines 102 - 104, The test mock path is outdated: update the vi.mock call to use the new module path '@pagespace/lib/monitoring/activity-tracker' so it correctly intercepts imports; specifically change the mock that provides trackAuthEvent (vi.mock(..., () => ({ trackAuthEvent: vi.fn() }))) to target '@pagespace/lib/monitoring/activity-tracker' to match the actual import used in the test.apps/web/src/app/api/drives/[driveId]/members/invite/__tests__/route.test.ts (1)
63-76:⚠️ Potential issue | 🟠 Major
vi.mockpath out of sync with import —trackDriveOperationwill not be mocked.Line 76 imports
trackDriveOperationfrom@pagespace/lib/monitoring/activity-tracker, but thevi.mock(...)on line 63 still targets the legacy alias@pagespace/lib/activity-tracker. Since this PR removes that old alias frompackages/lib/package.jsonexports, the mock registration targets a path that no longer exists while the actual import resolves to the new module — so the realtrackDriveOperationwill run in the test andexpect(trackDriveOperation).toHaveBeenCalledWith(...)in the "boundary obligations" suite will fail (or throw on module-resolution errors).🛠️ Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackDriveOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/drives/`[driveId]/members/invite/__tests__/route.test.ts around lines 63 - 76, The vi.mock call is targeting the old module path so trackDriveOperation is not being mocked; update the mock to match the actual import path used in the test (replace the '@pagespace/lib/activity-tracker' argument to vi.mock with '@pagespace/lib/monitoring/activity-tracker') so that the imported trackDriveOperation used by POST and assertions is a mocked vi.fn(); ensure the mock is declared before the import of POST and any other modules that import trackDriveOperation.apps/web/src/app/api/pages/__tests__/route.test.ts (1)
59-67:⚠️ Potential issue | 🟠 Major
vi.mocktarget still points to removed alias@pagespace/lib/activity-tracker.Line 67 now imports
trackPageOperationfrom@pagespace/lib/monitoring/activity-tracker, but thevi.mock(...)factory on line 59 still registers against the old path. With the old alias removed frompackages/lib/package.json, the mock no longer intercepts the real module — the "activity tracking" test that assertsexpect(trackPageOperation).toHaveBeenCalledWith(...)will exercise the real implementation (which writes to the DB vialogger-database) and likely fail.🛠️ Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackPageOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/pages/__tests__/route.test.ts` around lines 59 - 67, The test's vi.mock target is still the removed alias '@pagespace/lib/activity-tracker' so the imported trackPageOperation (from `@pagespace/lib/monitoring/activity-tracker`) isn't being mocked; update the vi.mock call to mock the correct module path '@pagespace/lib/monitoring/activity-tracker' and ensure the factory returns { trackPageOperation: vi.fn() } so the imported function used in the test (trackPageOperation) is intercepted and the expect(trackPageOperation).toHaveBeenCalledWith(...) assertion uses the mock.apps/web/src/app/api/auth/google/callback/__tests__/route.test.ts (1)
120-153:⚠️ Potential issue | 🟠 Major
vi.mockpath not updated alongside the import — mock is effectively dead.Line 153 imports
trackAuthEventfrom@pagespace/lib/monitoring/activity-tracker, butvi.mock(...)on line 120 still targets the legacy@pagespace/lib/activity-trackeralias that this PR removes. The mock won’t intercept the production module, so assertions likeexpect(trackAuthEvent).toHaveBeenCalledWith(...)in the "auth event logging", "tracks desktop auth events", and "tracks iOS auth events" tests will fail, and the real tracker (with DB writes) may run during unit tests.🛠️ Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/google/callback/__tests__/route.test.ts` around lines 120 - 153, The vi.mock target is pointing at the removed alias '@pagespace/lib/activity-tracker' so the actual imported symbol trackAuthEvent (imported from '@pagespace/lib/monitoring/activity-tracker') is not being mocked; update the vi.mock call to mock '@pagespace/lib/monitoring/activity-tracker' instead and ensure the mock exports trackAuthEvent (vi.fn()) so tests that call and assert on trackAuthEvent, and any other exported helpers from that module, are intercepted by the mock rather than hitting production code.apps/web/src/app/api/pages/[pageId]/export/markdown/__tests__/route.test.ts (1)
38-58:⚠️ Potential issue | 🔴 Critical
vi.mockspecifier not migrated — same issue as the DOCX/CSV/XLSX export tests.Line 38 mocks
@pagespace/lib/activity-tracker, but line 58 imports from@pagespace/lib/monitoring/activity-tracker. Mock won't intercept the new import; the "activity tracking" assertion on line 217 will run against the realtrackPageOperation.🐛 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackPageOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/pages/`[pageId]/export/markdown/__tests__/route.test.ts around lines 38 - 58, The test's vi.mock for activity tracking uses the wrong module specifier so the real trackPageOperation is imported; update the mock to target the actual import '@pagespace/lib/monitoring/activity-tracker' (and ensure it exports trackPageOperation as vi.fn()) so the imported trackPageOperation used in the test is mocked and the assertion around trackPageOperation will run against the mock.apps/web/src/app/api/auth/apple/callback/__tests__/route.test.ts (1)
90-128:⚠️ Potential issue | 🔴 Critical
vi.mockpath not migrated —trackAuthEventassertions will not be observing a spy.Line 90 mocks
@pagespace/lib/activity-tracker, but line 128 importstrackAuthEventfrom@pagespace/lib/monitoring/activity-tracker. The mock specifier doesn't match the real import specifier, so the "auth event logging" suite'sexpect(trackAuthEvent).toHaveBeenCalledWith(...)will be asserting against the real function rather than avi.fn().🐛 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/apple/callback/__tests__/route.test.ts` around lines 90 - 128, The test mocks the wrong module path so trackAuthEvent isn't a spy; change the vi.mock call that currently targets '@pagespace/lib/activity-tracker' to match the actual import '@pagespace/lib/monitoring/activity-tracker' and ensure the mock exports trackAuthEvent: vi.fn() so the imported trackAuthEvent used in the tests (from '@pagespace/lib/monitoring/activity-tracker') is the mocked spy being asserted against.apps/web/src/lib/websocket/__tests__/socket-utils.test.ts (1)
9-52:⚠️ Potential issue | 🔴 Critical
vi.mockspecifier forbroadcast-authnot updated to the newauth/subpath.Line 9 mocks
@pagespace/lib/broadcast-auth, but line 52 importscreateSignedBroadcastHeadersfrom@pagespace/lib/auth/broadcast-auth. The assertion on line 257 (expect(createSignedBroadcastHeaders).toHaveBeenCalled()) and the mocked signature header value on line 12 will no longer apply — the real implementation will be used, and if the old flat export was removed thevi.mockresolution itself may fail at setup.Note:
@pagespace/lib/logger-browseron line 16 should likewise be reviewed against the current package.json exports — if it was renamed to./logging/logger-browser, that mock is stale too.🐛 Proposed fix
-vi.mock('@pagespace/lib/broadcast-auth', () => ({ +vi.mock('@pagespace/lib/auth/broadcast-auth', () => ({ createSignedBroadcastHeaders: vi.fn((body: string) => ({ 'Content-Type': 'application/json', 'X-Broadcast-Signature': `t=1234567890,v1=mocksignature_${body.length}`, })), })); -vi.mock('@pagespace/lib/logger-browser', () => ({ +vi.mock('@pagespace/lib/logging/logger-browser', () => ({ browserLoggers: { /* ... */ }, }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/lib/websocket/__tests__/socket-utils.test.ts` around lines 9 - 52, Update the stale vi.mock specifier so the mocked export matches the actual import: change the mock that currently targets '@pagespace/lib/broadcast-auth' to '@pagespace/lib/auth/broadcast-auth' so createSignedBroadcastHeaders (used in tests and asserted with expect(createSignedBroadcastHeaders).toHaveBeenCalled()) is properly mocked; also verify and, if necessary, update the logger mock specifier (currently '@pagespace/lib/logger-browser') to the package's current export (e.g. './logging/logger-browser') so the browserLoggers.child mock remains effective.apps/web/src/app/api/account/devices/[deviceId]/__tests__/route.test.ts (1)
36-58:⚠️ Potential issue | 🔴 CriticalTwo
vi.mockspecifiers not migrated to the new subpaths.Lines 36 and 44 still mock the flat paths
@pagespace/lib/secure-compareand@pagespace/lib/device-auth-utils, while lines 56 and 58 importsecureCompareandrevokeDeviceTokenfrom the new@pagespace/lib/auth/*subpaths. Because the mock and import specifiers no longer match, the imported symbols will be the real implementations. Tests that callvi.mocked(secureCompare).mockReturnValue(...)andvi.mocked(revokeDeviceToken).mockResolvedValue(...)will throw ("mockReturnValue is not a function") or — worse — invoke real code paths (real DB mutation inrevokeDeviceToken).🐛 Proposed fix
-vi.mock('@pagespace/lib/secure-compare', () => ({ +vi.mock('@pagespace/lib/auth/secure-compare', () => ({ secureCompare: vi.fn(), })); -vi.mock('@pagespace/lib/device-auth-utils', () => ({ +vi.mock('@pagespace/lib/auth/device-auth-utils', () => ({ revokeDeviceToken: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/account/devices/`[deviceId]/__tests__/route.test.ts around lines 36 - 58, The test mocks use outdated module specifiers so the imported symbols secureCompare and revokeDeviceToken are not being mocked; update the vi.mock calls to the new subpaths used by the imports (replace '@pagespace/lib/secure-compare' with '@pagespace/lib/auth/secure-compare' and '@pagespace/lib/device-auth-utils' with '@pagespace/lib/auth/device-auth-utils') and keep the mocked exports named secureCompare and revokeDeviceToken respectively so vi.mocked(secureCompare) and vi.mocked(revokeDeviceToken) operate on the mocked functions.apps/web/src/app/api/pages/[pageId]/export/csv/__tests__/route.test.ts (1)
43-58:⚠️ Potential issue | 🟠 MajorPoint the activity-tracker mock at the renamed module.
The import moved to
@pagespace/lib/monitoring/activity-tracker, but the mock stayed on the old flat path, sotrackPageOperationis no longer mocked for these assertions.🧪 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackPageOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/pages/`[pageId]/export/csv/__tests__/route.test.ts around lines 43 - 58, The activity-tracker mock targets the old module path so trackPageOperation isn't being mocked; update the mock declaration to use the renamed module '@pagespace/lib/monitoring/activity-tracker' (the same module imported as trackPageOperation in the test) so vi.mock(...) replaces trackPageOperation; ensure the mocked export name matches the imported symbol trackPageOperation and keep the existing vi.fn() implementation used in the test assertions.apps/realtime/src/__tests__/auth.test.ts (1)
24-76:⚠️ Potential issue | 🟠 MajorUpdate the broadcast-auth mock to the renamed subpath.
The import now uses
@pagespace/lib/auth/broadcast-auth, but the mock is still registered for@pagespace/lib/broadcast-auth. This bypasses the mock and may also fail once the old export path is removed.🧪 Proposed fix
- * `@scaffold` - broadcast-auth lives in `@pagespace/lib` and may not resolve + * `@scaffold` - broadcast-auth lives in `@pagespace/lib/auth` and may not resolve @@ - * `@REVIEW` This test mocks `@pagespace/lib/broadcast-auth` and then tests the + * `@REVIEW` This test mocks `@pagespace/lib/auth/broadcast-auth` and then tests the @@ -vi.mock('@pagespace/lib/broadcast-auth', async () => { +vi.mock('@pagespace/lib/auth/broadcast-auth', async () => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/realtime/src/__tests__/auth.test.ts` around lines 24 - 76, The mock registration path is still '@pagespace/lib/broadcast-auth' so the imported symbols verifyBroadcastSignature, generateBroadcastSignature, and formatSignatureHeader (imported from '@pagespace/lib/auth/broadcast-auth') bypass the mock; update the vi.mock call to register the same renamed subpath by changing the module string to '@pagespace/lib/auth/broadcast-auth' (keeping the existing mock factory that defines generateBroadcastSignature, formatSignatureHeader, and verifyBroadcastSignature) so the mock and the import match.apps/web/src/app/api/drives/[driveId]/members/[userId]/__tests__/route.test.ts (1)
63-120:⚠️ Potential issue | 🟠 MajorKeep the activity-tracker mock in sync with the renamed import.
Line 120 imports the monitoring subpath, but the mock is still registered for the old flat path. That makes
trackDriveOperationa real import instead of thevi.fn()asserted later.🧪 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackDriveOperation: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/drives/`[driveId]/members/[userId]/__tests__/route.test.ts around lines 63 - 120, The test mocks trackDriveOperation from '@pagespace/lib/activity-tracker' but the test imports trackDriveOperation from '@pagespace/lib/monitoring/activity-tracker', causing the mock to not apply; update the vi.mock call to target the same module path used in the import (monitoring/activity-tracker) so that trackDriveOperation is a vi.fn() in tests, or change the import to match the mocked path—ensure the module path in the vi.mock and the import for trackDriveOperation are identical.apps/web/src/app/api/auth/device/refresh/__tests__/route.test.ts (1)
89-105:⚠️ Potential issue | 🟠 MajorUpdate the mock to the new activity-tracker subpath.
Line 105 imports
@pagespace/lib/monitoring/activity-tracker, but the test still mocks@pagespace/lib/activity-tracker. The spy assertions can hit the real module or fail once the legacy export is removed.🧪 Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/device/refresh/__tests__/route.test.ts` around lines 89 - 105, The test's mock for activity tracking uses the old module path; update the vi.mock call to mock the new subpath '@pagespace/lib/monitoring/activity-tracker' so the imported symbol trackAuthEvent (used in the test via import { trackAuthEvent } from '@pagespace/lib/monitoring/activity-tracker') is properly stubbed; specifically replace the existing vi.mock('@pagespace/lib/activity-tracker', ...) with vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn() })) so spy assertions reference the mocked trackAuthEvent.apps/web/src/app/api/track/__tests__/route.test.ts (1)
24-47:⚠️ Potential issue | 🔴 CriticalMock path mismatch — test will exercise real implementation.
vi.mock('@pagespace/lib/activity-tracker', ...)on line 24 still references the old subpath, but the import at line 47 now resolves@pagespace/lib/monitoring/activity-tracker. Since Vitest keys mocks by the resolved module specifier, the realtrackActivity/trackFeature/trackErrorwill be imported and thevi.fn()assertions (toHaveBeenCalledWith(...),not.toHaveBeenCalled()) will fail or cause real side effects (DB writes viawriteUserActivity).Proposed fix
-vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackActivity: vi.fn(), trackFeature: vi.fn(), trackError: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/track/__tests__/route.test.ts` around lines 24 - 47, The test's vi.mock call uses the old module specifier and doesn't match the actual imported module, so replace the mock key '@pagespace/lib/activity-tracker' with the resolved specifier '@pagespace/lib/monitoring/activity-tracker' (keeping the mocked exports trackActivity, trackFeature, trackError) so the imported symbols trackActivity/trackFeature/trackError are properly mocked and the vi.fn() assertions and side-effect prevention work as intended.apps/web/src/app/api/ai/global/[id]/usage/__tests__/route.test.ts (1)
42-52:⚠️ Potential issue | 🔴 CriticalMock path mismatch —
getContextWindowmock will not take effect.
vi.mock('@pagespace/lib/ai-monitoring', ...)at line 42 still uses the old specifier, while the actual import at line 52 (and the route under test) now resolves@pagespace/lib/monitoring/ai-monitoring. The mock factory will not intercept the real module, sogetContextWindowwill return its real value rather than the stubbed200000, andexpect(mockedCalculateUsageSummary).toHaveBeenCalledWith(usageLogs, getContextWindow)at line 259 compares against the real function reference instead of the mock.Proposed fix
-vi.mock('@pagespace/lib/ai-monitoring', () => ({ +vi.mock('@pagespace/lib/monitoring/ai-monitoring', () => ({ getContextWindow: vi.fn(() => 200000), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/ai/global/`[id]/usage/__tests__/route.test.ts around lines 42 - 52, The test is mocking the wrong module specifier so getContextWindow isn't stubbed; update the vi.mock call to target the actual module specifier used in the code under test (change vi.mock('@pagespace/lib/ai-monitoring', ...) to vi.mock('@pagespace/lib/monitoring/ai-monitoring', ...)) so the exported getContextWindow is replaced with the mock returning 200000, then rerun assertions that use getContextWindow (e.g., the expect on mockedCalculateUsageSummary receiving getContextWindow) to reference the mocked function.apps/web/src/app/api/auth/__tests__/verify-email.test.ts (1)
6-33:⚠️ Potential issue | 🔴 Critical
vi.mockpaths don't match the new import paths — mocks won't apply.The imports at lines 31 and 33 now use the nested subpaths (
@pagespace/lib/auth/verification-utils,@pagespace/lib/monitoring/activity-tracker), but thevi.mockcalls at lines 6 and 27 still target the old flat paths (@pagespace/lib/verification-utils,@pagespace/lib/activity-tracker). Since the old aliases were removed frompackages/lib/package.json, these mocks either fail to resolve or register against non-existent specifiers, leaving the real modules loaded for the actual imports. That will break the test suite (e.g.,vi.mocked(verifyToken).mockResolvedValue(...)inbeforeEachwon't control a mock).🛠️ Proposed fix
-vi.mock('@pagespace/lib/verification-utils', () => ({ +vi.mock('@pagespace/lib/auth/verification-utils', () => ({ verifyToken: vi.fn(), markEmailVerified: vi.fn().mockResolvedValue(undefined), })); @@ -vi.mock('@pagespace/lib/activity-tracker', () => ({ +vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent: vi.fn(), }));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/api/auth/__tests__/verify-email.test.ts` around lines 6 - 33, Update the vi.mock specifiers to match the new nested import paths so the mocks actually apply: replace the old '@pagespace/lib/verification-utils' mock with one for '@pagespace/lib/auth/verification-utils' (providing verifyToken and markEmailVerified), and replace '@pagespace/lib/activity-tracker' with '@pagespace/lib/monitoring/activity-tracker' (providing trackAuthEvent); keep the existing '@pagespace/lib/server' mock for loggers and ensure the mocked symbol names (verifyToken, markEmailVerified, trackAuthEvent, loggers) exactly match the imported identifiers used later in the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/realtime/src/__tests__/index.test.ts`:
- Around line 223-224: Update the test's vi.mock specifiers to match the new
nested import paths so the dynamic import picks up the mocks: change the
existing vi.mock(...) entries that target the old flat aliases to instead mock
'@pagespace/lib/logging/logger-config' for the loggers mock and
'@pagespace/lib/auth/broadcast-auth' for the verifyBroadcastSignature mock
(referencing the symbols loggers and verifyBroadcastSignature) so the dynamic
../index import loads the mocked implementations.
In `@apps/web/src/app/api/auth/google/callback/route.ts`:
- Line 10: The three calls to trackAuthEvent in the Google callback route are
sending raw email PII; update each payload to pass maskEmail(email) instead of
email (reuse the already-imported maskEmail helper) so trackAuthEvent never
receives raw emails — locate the trackAuthEvent invocations in route.ts (the
blocks around the login success/failure and account-creation events, e.g., the
calls currently passing email) and replace the email argument with
maskEmail(email) consistently (also apply the same change to the other instances
noted around the same file).
In `@apps/web/src/app/api/auth/magic-link/verify/__tests__/route.test.ts`:
- Around line 85-87: The Vitest mocks at the top of route.test.ts still target
the old flat aliases, so update them to mock the new nested import paths used in
the file: replace mocks for the old module names with mocks for
'@pagespace/lib/auth/verification-utils' (to mock markEmailVerified),
'@pagespace/lib/server' (to mock loggers and auditRequest), and
'@pagespace/lib/monitoring/activity-tracker' (to mock trackAuthEvent); ensure
vi.mock(...) calls use those exact subpaths and then use vi.mocked(...) against
the exported symbols markEmailVerified, loggers, auditRequest, and
trackAuthEvent so the test uses the mocked implementations.
In `@apps/web/src/app/api/pages/`[pageId]/__tests__/route.test.ts:
- Around line 73-74: The test's vi.mock calls still target the old module
aliases and therefore don't intercept the actual imports; update the vi.mock
targets to the new subpaths used by the imports—replace the old mock targets
with '@pagespace/lib/monitoring/activity-tracker' for trackPageOperation and
'@pagespace/lib/utils/api-utils' for jsonResponse (keeping the existing mock
implementations/returns intact) so the mocks apply to the imported symbols in
the test and the route.
---
Outside diff comments:
In `@apps/processor/src/__tests__/cors-validation.test.ts`:
- Around line 12-23: The test's vi.mock currently targets
'@pagespace/lib/logger-config' but the code under test imports from
'@pagespace/lib/logging/logger-config', so update the vi.mock call to mock the
exact module specifier '@pagespace/lib/logging/logger-config' and keep the same
mocked shape (loggers.processor.{debug,info,warn,error}); also ensure the
vi.mock is declared before importing the module-under-test or the named import
`loggers` so that `expect(loggers.processor.warn).toHaveBeenCalledWith(...)`
asserts against the mock.
In `@apps/realtime/src/__tests__/auth.test.ts`:
- Around line 24-76: The mock registration path is still
'@pagespace/lib/broadcast-auth' so the imported symbols
verifyBroadcastSignature, generateBroadcastSignature, and formatSignatureHeader
(imported from '@pagespace/lib/auth/broadcast-auth') bypass the mock; update the
vi.mock call to register the same renamed subpath by changing the module string
to '@pagespace/lib/auth/broadcast-auth' (keeping the existing mock factory that
defines generateBroadcastSignature, formatSignatureHeader, and
verifyBroadcastSignature) so the mock and the import match.
In `@apps/web/src/app/api/account/devices/`[deviceId]/__tests__/route.test.ts:
- Around line 36-58: The test mocks use outdated module specifiers so the
imported symbols secureCompare and revokeDeviceToken are not being mocked;
update the vi.mock calls to the new subpaths used by the imports (replace
'@pagespace/lib/secure-compare' with '@pagespace/lib/auth/secure-compare' and
'@pagespace/lib/device-auth-utils' with '@pagespace/lib/auth/device-auth-utils')
and keep the mocked exports named secureCompare and revokeDeviceToken
respectively so vi.mocked(secureCompare) and vi.mocked(revokeDeviceToken)
operate on the mocked functions.
In `@apps/web/src/app/api/ai/global/`[id]/usage/__tests__/route.test.ts:
- Around line 42-52: The test is mocking the wrong module specifier so
getContextWindow isn't stubbed; update the vi.mock call to target the actual
module specifier used in the code under test (change
vi.mock('@pagespace/lib/ai-monitoring', ...) to
vi.mock('@pagespace/lib/monitoring/ai-monitoring', ...)) so the exported
getContextWindow is replaced with the mock returning 200000, then rerun
assertions that use getContextWindow (e.g., the expect on
mockedCalculateUsageSummary receiving getContextWindow) to reference the mocked
function.
In `@apps/web/src/app/api/auth/__tests__/mobile-oauth-google-exchange.test.ts`:
- Around line 63-113: The vi.mock for the activity tracker uses the old
specifier and is therefore inert; update the mock call to target the new module
specifier '@pagespace/lib/monitoring/activity-tracker' (providing
trackAuthEvent: vi.fn()) and ensure this vi.mock appears before the import of
trackAuthEvent/route under test so the imported trackAuthEvent is the mocked fn
used in assertions.
In `@apps/web/src/app/api/auth/__tests__/verify-email.test.ts`:
- Around line 6-33: Update the vi.mock specifiers to match the new nested import
paths so the mocks actually apply: replace the old
'@pagespace/lib/verification-utils' mock with one for
'@pagespace/lib/auth/verification-utils' (providing verifyToken and
markEmailVerified), and replace '@pagespace/lib/activity-tracker' with
'@pagespace/lib/monitoring/activity-tracker' (providing trackAuthEvent); keep
the existing '@pagespace/lib/server' mock for loggers and ensure the mocked
symbol names (verifyToken, markEmailVerified, trackAuthEvent, loggers) exactly
match the imported identifiers used later in the test.
In `@apps/web/src/app/api/auth/apple/callback/__tests__/route.test.ts`:
- Around line 90-128: The test mocks the wrong module path so trackAuthEvent
isn't a spy; change the vi.mock call that currently targets
'@pagespace/lib/activity-tracker' to match the actual import
'@pagespace/lib/monitoring/activity-tracker' and ensure the mock exports
trackAuthEvent: vi.fn() so the imported trackAuthEvent used in the tests (from
'@pagespace/lib/monitoring/activity-tracker') is the mocked spy being asserted
against.
In `@apps/web/src/app/api/auth/apple/native/__tests__/route.test.ts`:
- Around line 87-121: The test's mock targets the old import path so
trackAuthEvent (used by POST route tests) isn't being mocked; update the vi.mock
call that currently targets '@pagespace/lib/activity-tracker' to mock the new
import '@pagespace/lib/monitoring/activity-tracker' and export trackAuthEvent:
vi.fn() (matching the imported symbol trackAuthEvent) so assertions referencing
trackAuthEvent are properly stubbed.
In `@apps/web/src/app/api/auth/device/refresh/__tests__/route.test.ts`:
- Around line 89-105: The test's mock for activity tracking uses the old module
path; update the vi.mock call to mock the new subpath
'@pagespace/lib/monitoring/activity-tracker' so the imported symbol
trackAuthEvent (used in the test via import { trackAuthEvent } from
'@pagespace/lib/monitoring/activity-tracker') is properly stubbed; specifically
replace the existing vi.mock('@pagespace/lib/activity-tracker', ...) with
vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({ trackAuthEvent:
vi.fn() })) so spy assertions reference the mocked trackAuthEvent.
In `@apps/web/src/app/api/auth/google/__tests__/one-tap.test.ts`:
- Around line 101-124: The test registers a Vitest mock for the wrong module
specifier so the imported trackAuthEvent (imported from
'@pagespace/lib/monitoring/activity-tracker') can be the real module; update the
vi.mock call to target the same subpath used by the import (replace the existing
vi.mock('@pagespace/lib/activity-tracker', ...) with
vi.mock('@pagespace/lib/monitoring/activity-tracker', ...) so trackAuthEvent is
a spy), then run the provided rg check to find any other stale vi.mock entries.
In `@apps/web/src/app/api/auth/google/callback/__tests__/route.test.ts`:
- Around line 120-153: The vi.mock target is pointing at the removed alias
'@pagespace/lib/activity-tracker' so the actual imported symbol trackAuthEvent
(imported from '@pagespace/lib/monitoring/activity-tracker') is not being
mocked; update the vi.mock call to mock
'@pagespace/lib/monitoring/activity-tracker' instead and ensure the mock exports
trackAuthEvent (vi.fn()) so tests that call and assert on trackAuthEvent, and
any other exported helpers from that module, are intercepted by the mock rather
than hitting production code.
In `@apps/web/src/app/api/auth/google/one-tap/__tests__/route.test.ts`:
- Around line 102-104: The test mock path is outdated: update the vi.mock call
to use the new module path '@pagespace/lib/monitoring/activity-tracker' so it
correctly intercepts imports; specifically change the mock that provides
trackAuthEvent (vi.mock(..., () => ({ trackAuthEvent: vi.fn() }))) to target
'@pagespace/lib/monitoring/activity-tracker' to match the actual import used in
the test.
In `@apps/web/src/app/api/auth/passkey/`[passkeyId]/__tests__/route.test.ts:
- Around line 29-43: The mocked module specifier is wrong: update the vi.mock
call that currently targets "@pagespace/lib/activity-tracker" to the new import
path "@pagespace/lib/monitoring/activity-tracker" so the mock applies to the
same module used by the route and tests, ensuring trackAuthEvent is the mocked
vi.fn() referenced by imports of trackAuthEvent and preventing real side
effects.
In
`@apps/web/src/app/api/drives/`[driveId]/members/[userId]/__tests__/route.test.ts:
- Around line 63-120: The test mocks trackDriveOperation from
'@pagespace/lib/activity-tracker' but the test imports trackDriveOperation from
'@pagespace/lib/monitoring/activity-tracker', causing the mock to not apply;
update the vi.mock call to target the same module path used in the import
(monitoring/activity-tracker) so that trackDriveOperation is a vi.fn() in tests,
or change the import to match the mocked path—ensure the module path in the
vi.mock and the import for trackDriveOperation are identical.
In
`@apps/web/src/app/api/drives/`[driveId]/members/invite/__tests__/route.test.ts:
- Around line 63-76: The vi.mock call is targeting the old module path so
trackDriveOperation is not being mocked; update the mock to match the actual
import path used in the test (replace the '@pagespace/lib/activity-tracker'
argument to vi.mock with '@pagespace/lib/monitoring/activity-tracker') so that
the imported trackDriveOperation used by POST and assertions is a mocked
vi.fn(); ensure the mock is declared before the import of POST and any other
modules that import trackDriveOperation.
In `@apps/web/src/app/api/pages/__tests__/route.test.ts`:
- Around line 59-67: The test's vi.mock target is still the removed alias
'@pagespace/lib/activity-tracker' so the imported trackPageOperation (from
`@pagespace/lib/monitoring/activity-tracker`) isn't being mocked; update the
vi.mock call to mock the correct module path
'@pagespace/lib/monitoring/activity-tracker' and ensure the factory returns {
trackPageOperation: vi.fn() } so the imported function used in the test
(trackPageOperation) is intercepted and the
expect(trackPageOperation).toHaveBeenCalledWith(...) assertion uses the mock.
In `@apps/web/src/app/api/pages/`[pageId]/export/csv/__tests__/route.test.ts:
- Around line 43-58: The activity-tracker mock targets the old module path so
trackPageOperation isn't being mocked; update the mock declaration to use the
renamed module '@pagespace/lib/monitoring/activity-tracker' (the same module
imported as trackPageOperation in the test) so vi.mock(...) replaces
trackPageOperation; ensure the mocked export name matches the imported symbol
trackPageOperation and keep the existing vi.fn() implementation used in the test
assertions.
In `@apps/web/src/app/api/pages/`[pageId]/export/markdown/__tests__/route.test.ts:
- Around line 38-58: The test's vi.mock for activity tracking uses the wrong
module specifier so the real trackPageOperation is imported; update the mock to
target the actual import '@pagespace/lib/monitoring/activity-tracker' (and
ensure it exports trackPageOperation as vi.fn()) so the imported
trackPageOperation used in the test is mocked and the assertion around
trackPageOperation will run against the mock.
In `@apps/web/src/app/api/pages/`[pageId]/export/xlsx/__tests__/route.test.ts:
- Around line 43-58: The test is mocking the old path for trackPageOperation so
the imported trackPageOperation used in the test isn't the mock; update the
vi.mock call to match the import path by replacing
vi.mock('@pagespace/lib/activity-tracker', ...) with
vi.mock('@pagespace/lib/monitoring/activity-tracker', () => ({
trackPageOperation: vi.fn() })), ensuring the mock exports the same symbol name
trackPageOperation so assertions against trackPageOperation in the tests use the
mock.
In `@apps/web/src/app/api/track/__tests__/route.test.ts`:
- Around line 24-47: The test's vi.mock call uses the old module specifier and
doesn't match the actual imported module, so replace the mock key
'@pagespace/lib/activity-tracker' with the resolved specifier
'@pagespace/lib/monitoring/activity-tracker' (keeping the mocked exports
trackActivity, trackFeature, trackError) so the imported symbols
trackActivity/trackFeature/trackError are properly mocked and the vi.fn()
assertions and side-effect prevention work as intended.
In `@apps/web/src/lib/websocket/__tests__/socket-utils.test.ts`:
- Around line 9-52: Update the stale vi.mock specifier so the mocked export
matches the actual import: change the mock that currently targets
'@pagespace/lib/broadcast-auth' to '@pagespace/lib/auth/broadcast-auth' so
createSignedBroadcastHeaders (used in tests and asserted with
expect(createSignedBroadcastHeaders).toHaveBeenCalled()) is properly mocked;
also verify and, if necessary, update the logger mock specifier (currently
'@pagespace/lib/logger-browser') to the package's current export (e.g.
'./logging/logger-browser') so the browserLoggers.child mock remains effective.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a1ebb432-229a-4e88-ab4d-a40b84dc5462
📒 Files selected for processing (98)
apps/processor/src/__tests__/cors-validation.test.tsapps/processor/src/api/ingest.tsapps/processor/src/middleware/auth.tsapps/processor/src/middleware/resource-binding.tsapps/processor/src/services/authorization.tsapps/processor/src/services/rbac.tsapps/processor/src/utils/cors-validation.tsapps/processor/src/workers/ocr-processor.tsapps/processor/src/workers/text-extractor.tsapps/realtime/src/__tests__/auth.test.tsapps/realtime/src/__tests__/index.test.tsapps/realtime/src/__tests__/origin-validation.test.tsapps/realtime/src/index.tsapps/realtime/src/kick-handler.tsapps/realtime/src/per-event-auth.tsapps/web/src/app/api/account/devices/[deviceId]/__tests__/route.test.tsapps/web/src/app/api/account/devices/[deviceId]/route.tsapps/web/src/app/api/account/devices/__tests__/route.test.tsapps/web/src/app/api/account/devices/route.tsapps/web/src/app/api/activities/[activityId]/rollback/route.tsapps/web/src/app/api/admin/global-prompt/route.tsapps/web/src/app/api/ai/chat/messages/[messageId]/undo/route.tsapps/web/src/app/api/ai/chat/route.tsapps/web/src/app/api/ai/global/[id]/messages/route.tsapps/web/src/app/api/ai/global/[id]/usage/__tests__/route.test.tsapps/web/src/app/api/ai/global/[id]/usage/route.tsapps/web/src/app/api/ai/page-agents/consult/route.tsapps/web/src/app/api/auth/__tests__/device-refresh.test.tsapps/web/src/app/api/auth/__tests__/logout.test.tsapps/web/src/app/api/auth/__tests__/mobile-oauth-google-exchange.test.tsapps/web/src/app/api/auth/__tests__/verify-email.test.tsapps/web/src/app/api/auth/apple/callback/__tests__/route.test.tsapps/web/src/app/api/auth/apple/callback/route.tsapps/web/src/app/api/auth/apple/native/__tests__/route.test.tsapps/web/src/app/api/auth/apple/native/route.tsapps/web/src/app/api/auth/device/refresh/__tests__/route.test.tsapps/web/src/app/api/auth/device/refresh/route.tsapps/web/src/app/api/auth/google/__tests__/one-tap.test.tsapps/web/src/app/api/auth/google/callback/__tests__/route.test.tsapps/web/src/app/api/auth/google/callback/route.tsapps/web/src/app/api/auth/google/native/__tests__/route.test.tsapps/web/src/app/api/auth/google/native/route.tsapps/web/src/app/api/auth/google/one-tap/__tests__/route.test.tsapps/web/src/app/api/auth/google/one-tap/route.tsapps/web/src/app/api/auth/logout/route.tsapps/web/src/app/api/auth/magic-link/send/route.tsapps/web/src/app/api/auth/magic-link/verify/__tests__/route.test.tsapps/web/src/app/api/auth/magic-link/verify/route.tsapps/web/src/app/api/auth/mobile/oauth/google/exchange/route.tsapps/web/src/app/api/auth/passkey/[passkeyId]/__tests__/route.test.tsapps/web/src/app/api/auth/passkey/[passkeyId]/route.tsapps/web/src/app/api/auth/passkey/authenticate/__tests__/route.test.tsapps/web/src/app/api/auth/passkey/authenticate/route.tsapps/web/src/app/api/auth/passkey/register/__tests__/route.test.tsapps/web/src/app/api/auth/passkey/register/route.tsapps/web/src/app/api/auth/signup-passkey/__tests__/route.test.tsapps/web/src/app/api/auth/signup-passkey/route.tsapps/web/src/app/api/auth/verify-email/route.tsapps/web/src/app/api/channels/[pageId]/messages/[messageId]/reactions/route.tsapps/web/src/app/api/channels/[pageId]/messages/route.tsapps/web/src/app/api/drives/[driveId]/members/[userId]/__tests__/route.test.tsapps/web/src/app/api/drives/[driveId]/members/[userId]/route.tsapps/web/src/app/api/drives/[driveId]/members/invite/__tests__/route.test.tsapps/web/src/app/api/drives/[driveId]/members/invite/route.tsapps/web/src/app/api/drives/[driveId]/pages/route.tsapps/web/src/app/api/drives/[driveId]/route.tsapps/web/src/app/api/drives/__tests__/route.test.tsapps/web/src/app/api/drives/route.tsapps/web/src/app/api/internal/monitoring/ingest/route.tsapps/web/src/app/api/messages/[conversationId]/route.tsapps/web/src/app/api/pages/[pageId]/__tests__/route.test.tsapps/web/src/app/api/pages/[pageId]/ai-usage/route.tsapps/web/src/app/api/pages/[pageId]/children/route.tsapps/web/src/app/api/pages/[pageId]/export/csv/__tests__/route.test.tsapps/web/src/app/api/pages/[pageId]/export/csv/route.tsapps/web/src/app/api/pages/[pageId]/export/docx/__tests__/route.test.tsapps/web/src/app/api/pages/[pageId]/export/docx/route.tsapps/web/src/app/api/pages/[pageId]/export/markdown/__tests__/route.test.tsapps/web/src/app/api/pages/[pageId]/export/markdown/route.tsapps/web/src/app/api/pages/[pageId]/export/xlsx/__tests__/route.test.tsapps/web/src/app/api/pages/[pageId]/export/xlsx/route.tsapps/web/src/app/api/pages/[pageId]/restore/route.tsapps/web/src/app/api/pages/[pageId]/route.tsapps/web/src/app/api/pages/[pageId]/view/route.tsapps/web/src/app/api/pages/__tests__/route.test.tsapps/web/src/app/api/pages/route.tsapps/web/src/app/api/pulse/cron/route.tsapps/web/src/app/api/pulse/generate/route.tsapps/web/src/app/api/track/__tests__/route.test.tsapps/web/src/app/api/track/route.tsapps/web/src/hooks/useAiUsage.tsapps/web/src/lib/ai/core/complete-request-builder.tsapps/web/src/lib/ai/tools/channel-tools.tsapps/web/src/lib/websocket/__tests__/socket-utils.test.tsapps/web/src/lib/websocket/calendar-events.tsapps/web/src/lib/websocket/socket-utils.tsapps/web/src/lib/workflows/workflow-executor.tspackages/lib/package.json
All three trackAuthEvent calls (web, desktop, iOS platforms) were passing the raw email address. maskEmail was already imported from @pagespace/lib/server and used in logger calls in the same file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2witstudios
added a commit
that referenced
this pull request
May 15, 2026
* refactor(lib): use real subdir paths in exports Replace 12 flat export aliases in @pagespace/lib with paths that match the actual source layout: - ./secure-compare, ./device-auth-utils, ./broadcast-auth, ./verification-utils → ./auth/* - ./activity-tracker, ./ai-monitoring, ./ai-context-calculator → ./monitoring/* - ./logger-config, ./logger-database, ./logger-browser, ./logger → ./logging/* - ./api-utils → ./utils/api-utils Updates 114 import statements across apps/web, apps/realtime, and apps/processor. Both exports and typesVersions fields in package.json updated in lockstep. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(lib): replace flat aliases in mocks and vitest configs The first pass only caught static `from '...'` imports. vi.mock(), vi.doMock(), await import(), and vitest.config alias maps also contained the old flat paths. Replace all remaining occurrences across apps/web, apps/realtime, and apps/processor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(auth): mask email in trackAuthEvent calls in Google OAuth callback All three trackAuthEvent calls (web, desktop, iOS platforms) were passing the raw email address. maskEmail was already imported from @pagespace/lib/server and used in logger calls in the same file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code