Repository navigation
fix(ai): remove duplicate PageSpace model aliases from selector - #210
Conversation
Model selectors were showing "Standard" and "Pro" twice because the AI_PROVIDERS.pagespace.models object contained both actual model IDs (glm-4.5-air, glm-4.7) and their aliases (standard, pro). The aliases are intended for internal storage/API use only and get resolved via resolvePageSpaceModel() before API calls. Removed the aliases from the models object to prevent duplicate UI entries. Updated isValidModel() to still accept aliases for PageSpace so agents with aiModel: 'standard' are validated correctly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughRemoved explicit PageSpace model alias entries (standard → glm-4.5-air, pro → glm-4.7) from AI_PROVIDERS configuration while adding validation logic to accept these aliases as valid models through the isValidModel function. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*ai*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/web/src/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Model selectors were showing "Standard" and "Pro" twice because the AI_PROVIDERS.pagespace.models object contained both actual model IDs (glm-4.5-air, glm-4.7) and their aliases (standard, pro).
The aliases are intended for internal storage/API use only and get resolved via resolvePageSpaceModel() before API calls. Removed the aliases from the models object to prevent duplicate UI entries.
Updated isValidModel() to still accept aliases for PageSpace so agents with aiModel: 'standard' are validated correctly.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.