refactor(lint): consolidate + relocate findMany rule fixtures (fast-follow to #2129)

[2witstudios]

Summary

Fast-follow to #2129 ("chore(lint): flag unbounded findMany calls — Phase 8 of task board crash-prevention epic", merged as 5258619c2).

#2129 was merged mid-review — after the Codex-review fixes landed (generalized the findMany receiver match, scoped the limit check to the top-level options object, replaced the file-wide warn override with 80 per-call-site suppressions) but before a proactive /simplify pass (4 parallel review agents: reuse, simplification, efficiency, altitude) had finished and its findings were pushed. That last commit (ac6c92e41) never made it into master. This PR carries just that commit, cherry-picked onto current master (the original branch's diff against current master was full of unrelated noise from other PRs merged in the meantime — this PR's diff is exactly the 9 files this commit touched, verified with git diff origin/master...HEAD --stat).

Reuse and efficiency came back clean in that pass. Two real, actionable findings, both applied here:

• Simplification: the original 6 single-purpose fixture files (apps/web/src/app/api/__fixtures__/) each duplicated ~3 lines of import/header boilerplate. Consolidated into 2 files grouped by scenario — db-handle-findmany-fixture.ts (plain db handle: unbounded / limited / findFirst) and alt-handle-and-nested-limit-findmany-fixture.ts (the tx-handle case and the nested-relation-limit case) — each case still its own independently-exercised exported function.
• Altitude: src/app/api/__fixtures__/ sat inside the real Next.js route tree. It happened to be silently skipped by two coverage-audit tests (drive-member-gate-coverage.test.ts, security-audit-coverage.test.ts) that filter by literal route.ts filename — incidental, not a structural exclusion, and a future coverage walker that scans by extension instead would trip over it. Moved to apps/web/src/__fixtures__/eslint-unbounded-findmany/ — still under src/ (so next lint's default scan dirs cover it — verified by temporarily adding an unsuppressed violation there and confirming bun run lint --filter=web failed on it, then reverting) but fully outside app/api/.

Also documented a known limitation directly in the rule's comment (apps/web/eslint.config.mjs): it's a syntactic AST pattern, not type-aware, so aliasing the query object first (const q = db.query.taskItems; q.findMany(...)) would evade it — the same class of gap the tx/database generalization in #2129 just closed for receiver identifiers. If that pattern shows up in practice, the durable fix is a typed wrapper in packages/db making limit a required parameter, not another AST special case.

No behavior change to the lint rule itself — same selector, same severity, same 80 pre-existing suppressions (just relocated/consolidated as fixture files, not touched as actual violation sites).

Epic: PageSpace page j44e35jwzlhr54fbmruk3k4i ("Task Board Query & Reorder Safety"), Phase 8.

Test plan

• bunx eslint src/__fixtures__/eslint-unbounded-findmany/ — clean, all 6 fixture cases behave as documented
• bun run lint --filter=web — 4/4 successful, no no-restricted-syntax output
• bun run typecheck --filter=web — green
• git diff origin/master...HEAD --stat — confirmed the diff is exactly the 9 files this commit touches, no unrelated drift

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

[coderabbitai]

Warning

Review limit reached

@2witstudios, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e803514-2141-40f8-ac3a-15be2f21b1fd

📥 Commits

Reviewing files that changed from the base of the PR and between 5258619 and b401b28.

📒 Files selected for processing (9)

• apps/web/eslint.config.mjs
• apps/web/src/__fixtures__/eslint-unbounded-findmany/alt-handle-and-nested-limit-findmany-fixture.ts
• apps/web/src/__fixtures__/eslint-unbounded-findmany/db-handle-findmany-fixture.ts
• apps/web/src/app/api/__fixtures__/alt-handle-findmany-fixture.ts
• apps/web/src/app/api/__fixtures__/alt-handle-limited-findmany-fixture.ts
• apps/web/src/app/api/__fixtures__/findfirst-fixture.ts
• apps/web/src/app/api/__fixtures__/limited-findmany-fixture.ts
• apps/web/src/app/api/__fixtures__/nested-limit-findmany-fixture.ts
• apps/web/src/app/api/__fixtures__/unbounded-findmany-fixture.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pu/eslint-findmany-fixture-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}