Repository navigation
fix(agents): make header CTAs mobile-friendly - #2310
Conversation
Button text labels now hidden below the sm breakpoint, showing only the + icon. Full labels appear at sm and up. Prevents the three-button row (New Drive / New Agent / New Session) from overflowing on narrow screens. Text nodes remain in the DOM (display: none via Tailwind hidden) so accessible names are preserved for tests and screen readers.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe agent header action buttons now have accessible labels, separate icon spacing, and responsive text visibility. Button labels remain visible from the ChangesAgent header actions
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f15655957
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses Codex P1: hidden span text is removed from the accessibility tree on mobile. Adding aria-label ensures screen readers always have a button name regardless of breakpoint.
Problem
The
/agentsheader row (New Drive / New Agent / New Session) overflows on mobile screens — three full-label buttons don't fit.Fix
Wrapped each button's text label in
<span className="hidden sm:inline ml-1">. On screens below thesmbreakpoint, only the+icon shows. Atsmand up, full labels appear as before.Text nodes stay in the DOM (
display: none, not removed) so accessible names are preserved for screen readers and existing tests.Test status
Tests couldn't run in sandbox due to a pre-existing
React.act is not a functionerror (React 19 / @testing-library/react version mismatch in this environment). The change is CSS-only — no logic, props, or event handlers touched.Files changed
apps/web/src/components/agents/AgentsListHeader.tsx(6 lines)Summary by CodeRabbit
Accessibility
UI Improvements