Repository navigation
feat(ui): make Pulse component collapsible - #340
Conversation
Add collapsible functionality to the Pulse summary component: - Wrap content in Radix UI Collapsible component - Add ChevronDown icon with rotation animation - Persist collapse state in useLayoutStore with localStorage - Keep refresh button accessible in collapsed header - Update skeleton to match new structure https://claude.ai/code/session_015mCMx2j2yFwjFnzWHiTFEX
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe Pulse panel UI component has been refactored to support collapsible functionality. A static card layout was replaced with a Collapsible component wrapper, the refresh button was restructured into an icon button group with a rotating chevron indicator, and collapse state is now persisted via a new layout store field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 506a9e3337
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/web/src/components/layout/left-sidebar/Pulse.tsx`:
- Around line 88-118: The CollapsibleTrigger Button currently contains another
interactive Button (the refresh control), creating invalid nested <button>
elements; move the refresh control out of the CollapsibleTrigger so the DOM
renders two sibling controls instead of a button inside a button. Concretely: in
the JSX that uses CollapsibleTrigger and Button (symbols: CollapsibleTrigger,
Button, RefreshCw, handleRefresh, isGenerating, pulseCollapsed, cn), render the
CollapsibleTrigger as the main trigger Button containing the "Pulse" heading and
the ChevronDown only, and render the refresh Button as a sibling element
immediately adjacent to that trigger (keeping its onClick with
e.stopPropagation(), disabled={isGenerating}, title/aria-label and the RefreshCw
icon with the animate-spin class). Ensure styling/layout classes are adjusted so
the two controls appear in the same row and the refresh click does not toggle
the collapsible.
… buttons Addresses review feedback from CodeRabbit and Codex about invalid HTML caused by nesting a Button inside the CollapsibleTrigger Button. Changes: - Wrap trigger and refresh button in a flex container - Move refresh button outside CollapsibleTrigger as a sibling element - Adjust styling to maintain the same visual layout - Add aria-label for accessibility
Add collapsible functionality to the Pulse summary component:
https://claude.ai/code/session_015mCMx2j2yFwjFnzWHiTFEX
Summary by CodeRabbit
Release Notes