fix: lib auth + services test quality to 9+ rubric

[2witstudios]

Summary

• Create repository seams (session-repository.ts, storage-repository.ts) to decouple session-service and storage-limits from direct ORM calls, enabling clean mocking
• Eliminate all as any type casts across 32 test files (replaced with vi.mocked(), as never, @ts-expect-error)
• Replace all bare toHaveBeenCalled() with meaningful argument assertions
• Fix flake risk in rate-limit-utils.test.ts (real setTimeout sleeps → vi.useFakeTimers())
• Fix env var restoration in oauth-utils-unit.test.ts (delete process.env[key] instead of = undefined)
• Add @scaffold labels to 13 files with ORM chain mocks pending future seam extraction
• Fix TypeScript errors in @scaffold test files by replacing vi.mocked(db) with explicit MockDb types matching each file's mock factory

5-Axis Rubric Scores (all 9+)

File	Contract	Mock	Assertion	Flake	Spec	Total
Auth
constants.test.ts	2	2	2	2	2	10
device-fingerprint-utils.test.ts	2	2	2	2	2	10
exchange-codes-impl.test.ts	2	2	2	2	2	10
exchange-codes.test.ts	2	2	2	2	2	10
opaque-tokens.test.ts	2	2	2	2	2	10
rate-limit-utils.test.ts	2	2	2	2	2	10
session-service-unit.test.ts	2	2	2	2	2	10
device-auth-utils.test.ts @scaffold	2	1	2	2	2	9
magic-link-service.test.ts @scaffold	2	1	2	2	2	9
oauth-utils-unit.test.ts @scaffold	2	1	2	2	2	9
passkey-service.test.ts @scaffold	2	1	2	2	2	9
session-abuse-vectors.test.ts @scaffold	2	1	2	2	2	9
token-lookup.test.ts @scaffold	2	1	2	2	2	9
verification-utils.test.ts @scaffold	2	1	2	2	2	9
account-lockout.test.ts @scaffold	—	—	—	—	—	N/A ¹
oauth-utils.test.ts	—	—	—	—	—	N/A ¹
session-service.test.ts	—	—	—	—	—	N/A ²
Services
date-utils.test.ts	2	2	2	2	2	10
email-service.test.ts	2	2	2	2	2	10
memory-monitor.test.ts	2	2	2	2	2	10
page-tree-cache.test.ts	2	2	2	2	2	10
shared-redis.test.ts	2	2	2	2	2	10
storage-limits.test.ts	2	2	2	2	2	10
subscription-utils.test.ts	2	2	2	2	2	10
upload-semaphore.test.ts	2	2	2	2	2	10
validated-service-token.test.ts	2	2	2	2	2	10
drive-member-service.test.ts @scaffold	2	1	2	2	2	9
drive-role-service.test.ts @scaffold	2	1	2	2	2	9
drive-search-service.test.ts @scaffold	2	1	2	2	2	9
drive-service.test.ts @scaffold	2	1	2	2	2	9
notification-email-service.test.ts @scaffold	2	1	2	2	2	9
rate-limit-cache.test.ts	—	—	—	—	—	N/A ¹

¹ Pre-existing failure on base branch (dependency resolution)
² Excluded by vitest config (integration test requiring live DB)

28/28 runnable files score 9+ ✓ (15 at 10/10, 13 at 9/10 @scaffold)

What @scaffold means

Files labeled @scaffold use ORM chain mocks (db.update().set().where().returning()) because the production code directly calls db. These tests are characterization tests — they verify behavior correctly but would break on internal refactoring. The fix is extracting repository seams (as done for session-service and storage-limits), which is planned for a follow-up.

TypeScript fix for scaffold tests

The vi.mocked(db) pattern can't properly infer mock methods on deeply nested Drizzle ORM query objects (e.g., db.query.users.findFirst), causing TS2339/TS2345 errors. Fixed by replacing with explicit MockDb type interfaces matching each file's mock factory, giving TypeScript clean access to .mockReturnValue(), .mockResolvedValueOnce(), etc.

Test plan

• All 28 runnable test files pass (520 tests)
• 4 pre-existing failures unchanged (verified on base branch via git stash)
• No production behavior changes (repository seams are pure refactors)
• All CI checks green (Unit Tests, Lint & TypeScript Check, Static Security Analysis, CodeQL, etc.)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Warning

Rate limit exceeded

@2witstudios has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1588cbd5-6df2-4167-8a76-5848ca3ba319

📥 Commits

Reviewing files that changed from the base of the PR and between 539b6a7 and 213e8fa.

📒 Files selected for processing (25)

• packages/lib/src/auth/__tests__/device-auth-utils.test.ts
• packages/lib/src/auth/__tests__/exchange-codes-impl.test.ts
• packages/lib/src/auth/__tests__/oauth-utils-unit.test.ts
• packages/lib/src/auth/__tests__/opaque-tokens.test.ts
• packages/lib/src/auth/__tests__/passkey-service.test.ts
• packages/lib/src/auth/__tests__/rate-limit-utils.test.ts
• packages/lib/src/auth/__tests__/session-abuse-vectors.test.ts
• packages/lib/src/auth/__tests__/session-service-unit.test.ts
• packages/lib/src/auth/__tests__/token-lookup.test.ts
• packages/lib/src/auth/__tests__/verification-utils.test.ts
• packages/lib/src/auth/session-repository.ts
• packages/lib/src/auth/session-service.ts
• packages/lib/src/monitoring/__tests__/activity-logger-compliance.test.ts
• packages/lib/src/services/__tests__/drive-member-service.test.ts
• packages/lib/src/services/__tests__/drive-role-service.test.ts
• packages/lib/src/services/__tests__/drive-search-service.test.ts
• packages/lib/src/services/__tests__/drive-service.test.ts
• packages/lib/src/services/__tests__/memory-monitor.test.ts
• packages/lib/src/services/__tests__/notification-email-service.test.ts
• packages/lib/src/services/__tests__/page-tree-cache.test.ts
• packages/lib/src/services/__tests__/storage-limits.test.ts
• packages/lib/src/services/__tests__/upload-semaphore.test.ts
• packages/lib/src/services/__tests__/validated-service-token.test.ts
• packages/lib/src/services/storage-limits.ts
• packages/lib/src/services/storage-repository.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pu/fix-lib-auth-svc

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}