Repository navigation
Enable cross-page sheet references and suggestion UX - #9
Merged
2witstudios merged 1 commit intoSep 24, 2025
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Comment on lines
+239
to
+264
| useEffect(() => { | ||
| setExternalSheets((prev) => { | ||
| const next: Record<string, ExternalSheetState> = {}; | ||
| let changed = false; | ||
|
|
||
| for (const reference of externalReferences) { | ||
| if (prev[reference.raw]) { | ||
| next[reference.raw] = prev[reference.raw]; | ||
| } else { | ||
| changed = true; | ||
| } | ||
| } | ||
|
|
||
| if (!changed && Object.keys(next).length === Object.keys(prev).length) { | ||
| return prev; | ||
| } | ||
|
|
||
| return next; | ||
| }); | ||
| }, [externalReferences]); | ||
|
|
||
| useEffect(() => { | ||
| externalReferences.forEach((reference) => { | ||
| const existing = externalSheets[reference.raw]; | ||
| if (existing && (existing.status === 'loading' || existing.status === 'ready')) { | ||
| return; |
There was a problem hiding this comment.
[P1] Load external sheets recursively to resolve nested references
External sheets are fetched only for tokens returned by collectExternalReferences(sheet) on the local sheet, but evaluation (evaluateSheet) can traverse formulas in those external sheets and request further resolveExternalReference lookups. Because externalReferences and the fetch effect here never expand to references discovered inside already loaded sheets, any transitive reference (e.g., A references B and B references C) will always yield "Referenced page \"C\" is loading" and never trigger a fetch for page C. This means nested cross‑page formulas cannot ever evaluate successfully even after the initial external sheet loads.
Useful? React with 👍 / 👎.
9 tasks
2witstudios
added a commit
that referenced
this pull request
Apr 10, 2026
Update for #865 (Redis export rate limit), #866 (activity log PII exclusion), #867 (activity chain serialization), #868-870 (audit service wiring), #863 (GDPR cron jobs), #861 (password auth removed). Fix code review comments: AI usage log deletion is explicit call not FK cascade; note shared-page assistant messages survive account deletion; resolve P2 #8 and #9 contradictions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2witstudios
added a commit
that referenced
this pull request
Apr 10, 2026
* docs: update compliance doc and prototype panes to reflect implemented fixes DSAR export, message hard-delete, AI log purge on account deletion, and audit chain verification are now implemented — update stale gap claims. Note in-progress work on pu/hash-chain-pii and pu/export-rate-limit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: reflect merged PRs and fix stale review comments Update for #865 (Redis export rate limit), #866 (activity log PII exclusion), #867 (activity chain serialization), #868-870 (audit service wiring), #863 (GDPR cron jobs), #861 (password auth removed). Fix code review comments: AI usage log deletion is explicit call not FK cascade; note shared-page assistant messages survive account deletion; resolve P2 #8 and #9 contradictions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: fix stale password auth reference, add userId:null caveat Section 7.1 referenced "local email+password auth" — password auth was removed in #861; on-prem now uses magic links + passkeys. GdprPane message deletion cards now note shared-page assistant messages with userId: null may survive account deletion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(prototype): restructure panes so resolved items live in Current Resolved items were sitting in Gaps/End Game with "Fixed"/"Done" labels, breaking the narrative flow. Now: - Current: hash chain integrity, distributed rate limit, message hard-delete all live in their natural subsections - Gaps: only genuine gaps remain (cookie consent, data residency, SIEM, audit coverage, agent trails) - End Game: only future work (no "Done" items cluttering the roadmap) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d423871cf88320bb76531e99151135