vms-6a49: correct the stale/false concealed-rooted-compose caveat in loginout_acp (compose is done + proven) - #1045
Merged
Conversation
…test_syssvc_loginout_acp
Measure-first (3rd disproof in this lane, after vms-03b/vms-058): the concealed-
rooted logical composition the caveat says is missing is DONE and proven on
origin/main. The iterative translation (compose_ods2_r, vmsfs_translate.c:774),
concealed-rooted concatenation (merge_rooted_root :603, LNM$M_CONCEALED), and
boot-time definitions (lnm_setup_defaults seeds concealed-rooted SYS$SYSROOT/
SYS$COMMON) are all wired into the RMS-over-ACP open path (rms_acp_specs_from_fab
-> vmsfs_compose_ods2_candidates, rms_core.c:368) and proven end-to-end on a live
executive:
- test_syssvc_sysuaf_uic_base / _rightslist / _setuai do a real RMS $OPEN of
SYS$SYSTEM:SYSUAF.DAT (sysuaf_lookup -> rms_open_named_handle) and read the
real record off the ACP;
- test_syssvc_dirlogical_acp walks the concealed-rooted chain to the file FID
(teeth: negctl dirlogical-compose-drops-common-member);
- tests/vmsrms/test_dirlogical_compose proves the compose via the real
lnm_setup_defaults host-side.
test_syssvc_loginout_acp.c still carried the stale #649 "does not yet compose"
caveat -- the exact false premise that seeded the whole vms-058 trail -- plus a
top-of-file ISOLATION note claiming the test redefines SYS$SYSTEM: -> [OVMXDIR]
(it does not; assertion 4 proves SYS$SYSTEM: fails-honest, which that redefinition
would contradict).
Correct both to reality: the compose IS wired + proven elsewhere; THIS suite's
real-VAX fixture carries only [OVMXDIR] (no [SYS0.SYSCOMMON.SYSEXE] system tree),
so the product SYS$SYSTEM:SYSUAF.DAT composes to on-volume candidates absent on
this volume and resolves fail-honest (RMS$_FNF) -- a fixture property, not a
missing compose. Assertion (4)'s label updated to the accurate reason. The
assertions are unchanged (the suite stays green); full boot-time login through
the product's own SYS$SYSTEM: against a real system tree remains vms-ead (a
full-boot proof, not a composition gap).
Comment/label only; no functional change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scoped child of vms-ed7, carved to unblock vms-ead (boot login through the product's own
SYS$SYSTEM:). Measure-first (the third disproof in this lane, after vms-03b and vms-058): the concealed-rooted logical composition the item was to "land" is already DONE and comprehensively proven on origin/main.compose_ods2_rrecursion (src/vmsfs/vmsfs_translate.c:774), depth-guarded.equiv_is_rooted(:526) +merge_rooted_root(:603), honoringLNM$M_CONCEALED([SYS0.SYSCOMMON.]+[SYSEXE]→[SYS0.SYSCOMMON.SYSEXE]).lnm_setup_defaultsseeds concealed-rootedSYS$SYSROOT/SYS$COMMON(ovmx_init.c:1471).$OPEN/$CREATE/$SEARCH—rms_acp_specs_from_fab→vmsfs_compose_ods2_candidates(rms_core.c:368).And proven end-to-end on a live executive:
test_syssvc_sysuaf_uic_base/_rightslist/_setuai— a real RMS$OPENofSYS$SYSTEM:SYSUAF.DAT(sysuaf_lookup→rms_open_named_handle) reads the real record off the ACP.test_syssvc_dirlogical_acp— walks the concealed-rooted chain to the file FID (teeth:dirlogical-compose-drops-common-member).tests/vmsrms/test_dirlogical_compose— the compose via the reallnm_setup_defaults, host-side.So the conductor's "missing depth" hypothesis is disproved: no product gap, and the requested
$OPEN-through-a-concealed-rooted-logical proof already exists.The one real defect fixed
test_syssvc_loginout_acp.cstill carried the stale#649"does not yet compose" caveat — the exact false premise that seeded the whole vms-058 trail — plus a top-of-file note claiming the suite redefinesSYS$SYSTEM:→[OVMXDIR](it does not; assertion 4 provesSYS$SYSTEM:fails-honest, which that redefinition would contradict).This corrects both to reality: the compose is wired + proven elsewhere; this suite's real-VAX fixture carries only
[OVMXDIR](no[SYS0.SYSCOMMON.SYSEXE]system tree), so the productSYS$SYSTEM:SYSUAF.DATcomposes to on-volume candidates absent on this volume and resolves fail-honest (RMS$_FNF) — a fixture property, not a missing compose. Assertion (4)'s label is updated to the accurate reason.Comment/label only — the assertions are unchanged, so the suite stays green. Full boot-time login through the product's own
SYS$SYSTEM:against a real system tree remains vms-ead (a full-boot proof, which the conductor runs), not a composition gap.🤖 Generated with Claude Code