Skip to content

Align resource key and data file environment variables#121

Merged
Automation51D merged 1 commit into
mainfrom
feature/align-environment-variables
Jun 12, 2026
Merged

Align resource key and data file environment variables#121
Automation51D merged 1 commit into
mainfrom
feature/align-environment-variables

Conversation

@jwrosewell

@jwrosewell jwrosewell commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

This change aligns the environment variable names used by the test helpers with the convention shared across 51Degrees repositories.

  • KeyUtils gains an aligned-first lookup. The 51DEGREES_RESOURCE_KEY name is checked first as an environment variable or system property, with the legacy TestResourceKey name retained and checked second.
  • FileUtils checks the 51DEGREES_IPI_PATH name for an explicit data file path before the existing project space search, which is unchanged.
  • The README documents the resolution order.

Notes

  • Maven -D parameter names used by CI are unchanged, so existing pipelines keep working.
  • GitHub workflow secret references are unchanged. An accompanying issue advises on the aligned secret naming.
  • The aligned names start with a digit, which POSIX shells do not accept in plain assignments. On Linux and macOS set them with the env command or pass them as system properties, for example mvn test -D51DEGREES_RESOURCE_KEY=AAA.

Test helpers now check the aligned 51DEGREES_RESOURCE_KEY name
(environment variable or system property) before the legacy
TestResourceKey, and the aligned 51DEGREES_IPI_PATH name before
searching the project space for a data file. Developer-facing
messages and the README now reference the aligned names.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Automation51D Automation51D merged commit 9d0a379 into main Jun 12, 2026
@Automation51D Automation51D deleted the feature/align-environment-variables branch June 12, 2026 09:42
jwrosewell added a commit that referenced this pull request Jun 12, 2026
…Align resource key and data file environment variables'

Test helpers now check the aligned 51DEGREES_RESOURCE_KEY name
(environment variable or system property) before the legacy
TestResourceKey, and the aligned 51DEGREES_IPI_PATH name before
searching the project space for a data file. Developer-facing
messages and the README now reference the aligned names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants