You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These imports don't work if you've installed a version of react-query before v4, whose imports have to look like this:
import{UseQueryResult}from"react-query";
Describe the solution you'd like
List react-query v4 and up as a peer dependency of this package
Describe alternatives you've considered
This tool could also support generating v3-style imports with a CLI option. That said, I could see how supporting old versions of react-query could go far beyond this one incompatibility, and I could see officially how providing that support could potentially significantly increase the maintenance demand of this package.
I suppose I could also run a string-replace to change @tanstack/react-query to react-query on every generated file.
Our api does not support that version of react query. That package should be changed to use the package under the TanStack name.
That's fine! That's why I suggested listing the tanstack-named package as a peer dependency, so that those using older versions get a warning message when they install the package.
Activity
seriouslag commentedon Jul 25, 2024
Our api does not support that version of react query. That package should be changed to use the package under the @TanStack name.
IzzyLeeDev commentedon Aug 2, 2024
That's fine! That's why I suggested listing the tanstack-named package as a peer dependency, so that those using older versions get a warning message when they install the package.
feat: declare @tanstack/react-query as a peer dependency and widen co…