Repository navigation
feat(cases): add role-filtered map view endpoint - #141
Conversation
- expose GET /api/cases/{case_id}/map-view for case members
- return places, tasks, confirmed clues, and last-seen text fallbacks
- filter map layers by family, commander, and volunteer permissions
- preserve records without coordinates for deterministic text location fallback
- exclude predicted locations and unauthorized internal data
- document the endpoint and map-view response schemas in API and OpenAPI docs
- add authentication and role-based map-view integration tests
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthrough新增 Changes案件地图视图
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant get_map_view
participant case_service
participant task_service
Client->>get_map_view: GET /api/cases/{case_id}/map-view
get_map_view->>case_service: 获取案件详情
get_map_view->>task_service: 分页查询案件任务
get_map_view-->>Client: 返回按角色裁剪的地图条目
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 oasdiff (1.23.0)docs/openapi.yamlError: failed to load base spec from "/tmp/coderabbit-oasdiff-base.LdFQrU": failed to unmarshal data: json error: invalid character 'o' looking for beginning of value, yaml error: error converting YAML to JSON: yaml: line 1275: found character that cannot start any token Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
tests/api/case_map_view_get.rs (1)
71-85: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win建议补上两个关键负向/边界断言。
当前用例验证了"已确认线索出现在指挥视图"，但没有覆盖裁剪逻辑最有风险的反向分支：
- 未确认线索（
pending_review）不得出现在指挥地图层。src/api/routes/cases.rs第 276 行的status == "confirmed"过滤一旦写反或被删除，会把未审核线索当作地图态势暴露，而现有断言全部会继续通过。- 无坐标记录的文本回退——本 PR 的核心行为——目前只由
last_seen间接覆盖。建议再建一个不带经纬度的 place 或线索，断言其longitude/latitude为null且location_text非空、location_precision == "unknown"。依据路径指令：
tests/**需检查改动行为具备有意义的正向、负向与边界覆盖。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/api/case_map_view_get.rs` around lines 71 - 85, 增强 case_map_view_get 测试中的边界覆盖：断言 pending_review 状态的线索不会出现在 commander_items 中；另外创建一个无经纬度的 place 或线索，并断言其 longitude 和 latitude 为 null、location_text 非空且 location_precision 为 "unknown"。保留现有已确认线索和 last_seen 的正向断言。Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/openapi.yaml`:
- Around line 2200-2201: 将 OpenAPI 中 cases 对象的 occurred_at 声明与其数据源字段保持一致，移除该字段的
format: date-time，仅保留 [string, "null"] 类型；不要修改 reported_at 或
ElderProfile.last_seen_at、Clue.occurred_at 的现有声明。
In `@src/api/routes/cases.rs`:
- Around line 219-228: Update the task-loading flow around the list_tasks call
so it does not silently stop at the first 100 tasks: use the returned
tasks.total to request and aggregate every page, or explicitly expose total and
truncation information in the response if pagination must remain limited.
Preserve the existing task mapping behavior while ensuring clients can detect
incomplete results.
- Around line 233-247: Update the last-seen CaseMapItem construction in the case
map route so the self-reported elder_profile.last_seen_location is not marked as
confirmed; use the appropriate unverified/pending review_status and preserve the
corresponding API semantics. Replace the hardcoded “Last confirmed location”
display_name with the object_type-driven client-localized behavior, then
synchronize the changed review_status contract in tests/api/case_map_view_get.rs
and docs/openapi.yaml.
---
Nitpick comments:
In `@tests/api/case_map_view_get.rs`:
- Around line 71-85: 增强 case_map_view_get 测试中的边界覆盖：断言 pending_review 状态的线索不会出现在
commander_items 中；另外创建一个无经纬度的 place 或线索，并断言其 longitude 和 latitude 为
null、location_text 非空且 location_precision 为 "unknown"。保留现有已确认线索和 last_seen
的正向断言。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fd1e3171-836b-4018-b4bb-47291434ab80
📒 Files selected for processing (7)
docs/API.mddocs/openapi.yamlsrc/api/models.rssrc/api/routes/cases.rstests/api/authentication_guards.rstests/api/case_map_view_get.rstests/api/mod.rs
| occurred_at: { type: [string, "null"], format: date-time } | ||
| reported_at: { type: [string, "null"], format: date-time } |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
occurred_at 标注 format: date-time 与实际数据源不符。
occurred_at 的取值来自 elder_profile.last_seen_at（src/api/routes/cases.rs 第 242 行）和 clue.occurred_at（第 288 行），而本文件中 ElderProfile.last_seen_at（第 1895-1896 行）与 Clue.occurred_at（第 1945-1946 行）都刻意声明为无 format 的 [string, "null"]，因为服务端只做 trim、不解析时间格式。这里加上 format: date-time 会让契约校验对同一份数据给出相互矛盾的结论。
📝 建议对齐既有字段声明
- occurred_at: { type: [string, "null"], format: date-time }
+ occurred_at:
+ type: [string, "null"]
+ description: 可能直接透传未经格式校验的案件/线索时间文本，不保证是 RFC 3339。
reported_at: { type: [string, "null"], format: date-time }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| occurred_at: { type: [string, "null"], format: date-time } | |
| reported_at: { type: [string, "null"], format: date-time } | |
| occurred_at: | |
| type: [string, "null"] | |
| description: 可能直接透传未经格式校验的案件/线索时间文本，不保证是 RFC 3339。 | |
| reported_at: { type: [string, "null"], format: date-time } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/openapi.yaml` around lines 2200 - 2201, 将 OpenAPI 中 cases 对象的
occurred_at 声明与其数据源字段保持一致，移除该字段的 format: date-time，仅保留 [string, "null"] 类型；不要修改
reported_at 或 ElderProfile.last_seen_at、Clue.occurred_at 的现有声明。
- fetch all task pages instead of limiting map results to 100 tasks - guard page increments and item count conversions against overflow - add integration coverage for map views containing more than 100 tasks
Preview readyThe preview for this build is available at https://pr-141-82676a4b777f.angui.cg8.site. Temporary demo accounts (all use the password
|
- return null display names for last-seen map items - prevent clients from presenting last-seen data as confirmed - update OpenAPI and API documentation for localized labels - add map-view coverage for pending-review last-seen entries
close #28
Summary by CodeRabbit
GET /api/cases/{case_id}/map-view：以统一地图条目返回地点、线索、任务与最近确认位置，按访问角色裁剪可见内容，并明确不包含预测位置。pending_review且display_name为null（不展示为确认进展）。