This repository was archived by the owner on Jul 16, 2026. It is now read-only.
Repository navigation
Conversation
…ded lianghaochen path The default fallback in memory_dir() was hardcoded to `-Users-lianghaochen-stando`, which broke the function for every user other than the original author. Replace it with a derived slug from REPO_DIR (same slug format Claude Code uses for its project directories). Also honor the legacy SUTANDO_PRIVATE_DIR alias, matching util_paths.py's _memory_dir_env() behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without a timeout, tar can hang indefinitely on a full disk, slow NFS mount, or corrupted archive — blocking the upload/hydrate command permanently. 120s is generous for typical memory + notes directories (usually a few MB of markdown). TimeoutExpired returns False from _make_tarball (upload skips) and exit code 3 from cmd_hydrate (same as CalledProcessError). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bassilkhilo-ag2
approved these changes
Jun 5, 2026
bassilkhilo-ag2
left a comment
bassilkhilo-ag2
left a comment
There was a problem hiding this comment.
Two solid fixes: (1) the hardcoded lianghaochen path replaced with a repo-derived slug via claude_home_path — this was a portability bug affecting every non-lianghaochen installation. (2) Also honors SUTANDO_PRIVATE_DIR (legacy alias, per CLAUDE.md). Timeout=120 on tar subprocesses is good defensive coding — large memory dirs could hang indefinitely. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_dir()fallback was hardcoded to"-Users-lianghaochen-stando"— broken for every user except the original authorclaude_home_path("projects", slug, "memory")whereslug = str(REPO_DIR).replace("/", "-")— the same derivation Claude Code uses for its per-project directoriesSUTANDO_PRIVATE_DIRalias (mirrorsutil_paths._memory_dir_env())Test plan
memory_dir()smoke-tested locally: returns~/.claude/projects/-Users-<host>-Development-core-prod-stando/memorywhenSUTANDO_MEMORY_DIRis unsetSUTANDO_MEMORY_DIRset, still uses the explicit env var (path unchanged)🤖 Generated with Claude Code