Skip to content
This repository was archived by the owner on Jul 16, 2026. It is now read-only.

fix(health-check): route ngrok + conversation-server logs to workspace logs/ - #104

Open
jgluck96 wants to merge 1 commit into
mainfrom
fix/health-check-tmp-log-paths
Open

jgluck96 wants to merge 1 commit into
mainfrom
fix/health-check-tmp-log-paths

Conversation

@jgluck96

@jgluck96 jgluck96 commented Jun 4, 2026

Copy link
Copy Markdown

Summary

  • ngrok and conversation-server restart paths in health-check.py were writing logs to /tmp/ngrok.log and /tmp/conversation-server.log
  • Every other service (discord-bridge, agent-api, dashboard, voice-agent, etc.) already uses WORKSPACE_DIR / "logs" / "<name>.log"
  • The /tmp/ paths are cleared on reboot and invisible to anything that reads the workspace logs/ directory
  • startup.sh guarantees WORKSPACE_DIR/logs/ exists before health-check runs, so no mkdir guard needed

Test plan

  • Verified startup.sh creates WORKSPACE_DIR/logs/ at line 38 before any service starts
  • Verified WORKSPACE_DIR is defined and in scope at the callsites
  • CI tsc + tests

🤖 Generated with Claude Code

…e logs/

Both services were logging to /tmp/ while every other service (discord-bridge,
agent-api, dashboard, etc.) logs to WORKSPACE_DIR/logs/. The /tmp/ paths are
wiped on reboot and invisible to anything that reads the workspace logs
directory. startup.sh ensures logs/ exists before health-check runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@bassilkhilo-ag2 bassilkhilo-ag2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Routing ngrok and conversation-server logs to WORKSPACE_DIR/logs/ instead of /tmp/ keeps runtime state inside the workspace where build_log.md, dashboard, and health-check all know to look. Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants