This repository was archived by the owner on Jul 16, 2026. It is now read-only.
Repository navigation
Conversation
… not repo root
WORKSPACE_DIR fell back to join(dirname(__file__), '../../..') = repo root
when SUTANDO_WORKSPACE was unset. startup.sh never exports SUTANDO_WORKSPACE,
so the fallback was always used.
Impact: phone task files (TASKS_DIR), results (RESULTS_DIR), and
conversation.log all landed in <repo>/ instead of ~/.sutando/workspace/.
voice-agent reads conversation.log via statePath('conversation.log') =
<workspace>/conversation.log, so cross-agent context was silently empty
for every phone call.
Fix: import resolveWorkspace() (already used by discord-voice-server.ts
for the same purpose); add REPO_DIR = dirname(__file__)/../../.. for
the one call that legitimately needs the repo path (scan-call-logs.py).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bassilkhilo-ag2
approved these changes
Jun 5, 2026
bassilkhilo-ag2
left a comment
bassilkhilo-ag2
left a comment
There was a problem hiding this comment.
LGTM. Correctly splits WORKSPACE_DIR (resolveWorkspace) from REPO_DIR (dirname/import.meta.url) in conversation-server — scan-call-logs.py is a code-adjacent path so REPO_DIR is right there.
bassilkhilo-ag2
approved these changes
Jun 5, 2026
bassilkhilo-ag2
left a comment
bassilkhilo-ag2
left a comment
There was a problem hiding this comment.
LGTM. Correctly splits WORKSPACE_DIR (resolveWorkspace) from REPO_DIR (dirname/import.meta.url) in conversation-server — scan-call-logs.py is a code-adjacent path so REPO_DIR is right there.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation-server.tshad:startup.shnever exportsSUTANDO_WORKSPACE, so the fallback was always the repo root.Impact — all of these landed in
<repo>/instead of~/.sutando/workspace/:TASKS_DIR(tasks/) — phone tasks written to repo root, never picked up by ClaudeRESULTS_DIR(results/) — phone results written to repo root, DMs never deliveredconversation.log—voice-agent.tsreads this viastatePath('conversation.log')=<workspace>/conversation.log; phone side wrote to<repo>/conversation.log→ cross-agent context was silently empty for every phone calldiscord-voice-server.ts(sister file) already usesresolveWorkspace()correctly — this alignsconversation-server.tsto the same pattern.Fix
resolveWorkspace()from../../../src/workspace_default.jsWORKSPACE_DIR = resolveWorkspace()→~/.sutando/workspace/REPO_DIRfor the one call that legitimately needs the repo path (src/scan-call-logs.py)Test plan
npx tsc --noEmit— cleannpm test— 240/240 pass~/.sutando/workspace/tasks/(not repo root)conversation.logappended in~/.sutando/workspace/→ voice-agent has phone context🤖 Generated with Claude Code