[jgluck96]

Summary

• Adds 6 unit tests for _shouldFallthrough introduced in PR harden(task-bridge): PR #982 field-ordering + #1035 fallthrough guard #70
• Tests cover: allows task- / voice- / proactive-; blocks dvoice- / result- / empty string
• Closes the test gap called out in PR harden(task-bridge): PR #982 field-ordering + #1035 fallthrough guard #70's description

Dependencies

• Targets josh/phase-5.1-task-bridge-hardening — merge harden(task-bridge): PR #982 field-ordering + #1035 fallthrough guard #70 first, then merge this

Test plan

• npm test — all 6 new cases pass

🤖 Generated with Claude Code

[bassilkhilo-ag2]

Tests look good for the current implementation, but the allowlist in PR #70 needs to be extended before these tests are complete.

PR #70's _shouldFallthrough is missing 4 prefixes that the voice path relies on: question-, briefing-, insight-, friction- (see my change-request review on #70). Once Josh adds those to the allowlist, this test file will need matching test cases:

it('allows question- prefix', () => {
    assert.equal(_shouldFallthrough('question-1748800000000.txt'), true);
});
it('allows briefing- prefix', () => {
    assert.equal(_shouldFallthrough('briefing-1748800000000.txt'), true);
});
it('allows insight- prefix', () => {
    assert.equal(_shouldFallthrough('insight-1748800000000.txt'), true);
});
it('allows friction- prefix', () => {
    assert.equal(_shouldFallthrough('friction-1748800000000.txt'), true);
});

Please update alongside the PR #70 fix so both land together.