Fix Gemma-3 4B Multimodal SFT test script#4268
Merged
Merged
Conversation
b1c5d42 to
a4e1ea6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a4e1ea6 to
d2658b8
Compare
…enizer and run_name
d2658b8 to
fe4cb35
Compare
hengtaoguo
approved these changes
Jun 25, 2026
SurbhiJainUSC
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple bugs and configuration issues in Step 4 of the Gemma-3 4B Multimodal SFT end-to-end test script:
run_name=${run_id}}(with a trailing curly bracket) torun_name=${run_id}.tokenizer_type=huggingfaceto Step 4. Without this, MaxText defaults to a SentencePiece tokenizer and attempts to load a local.modelfile at the Hugging Face repo pathgoogle/gemma-3-4b-it, resulting in the following error:Description of the issue we found
Without the
tokenizer_type=huggingfaceflag, Step 4 of the end-to-end Gemma-3 SFT test crashes upon parameter loading when it tries to find a local SentencePiece model path undergoogle/gemma-3-4b-itinstead of fetching the proper Hugging Face config.Tests
We tested this change end-to-end on a v6e TPU VM:
tests/end_to_end/tpu/gemma3/4b/test_gemma3_multimodal_sft.shusing a unique run ID.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.