Repository navigation
[hrx-llama] update compatability floor - #166
Open
AaronStGeorge wants to merge 1 commit into
Open
AaronStGeorge wants to merge 1 commit into
AaronStGeorge wants to merge 1 commit into
Conversation
Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recorded HRX minimum predates dependencies already used by this backend: the
loom-benchmarkbuild target andcheck.expect.approximatein the kernel corpus. Raisehrx-minimum-commit.txtfrom771711d49befd397f10c3c6deb66f1c5c89e5042tod03575e84f602d3e39b87895a30fae214f308558.d03575e84ffirst adds the required typed expectation operation (merged by7c0f021226, HRX ggml-org#2418). It contains both the old floor and the earlier execution-tool renamebdf3e0ceeein its ancestry. Its immediate parent,d270efd38c, rejects the exact expectation statement fromgather_add_f32.loom; the selected revision parses it successfully. This selects the earliest demonstrated dependency revision, before the previously tested82214dfb02.Validation against llama.cpp
2120f7434plus this one-line change, using HRX at the exact new floor:10.1.0a20260822-1100, ROCm Clang, and compiler caching disabled. Built HRX/Loom, the binary kernel corpus, all four HRX suites,llama-bench, andllama-clithroughGGML_HRX=ONandHRX_SOURCE_DIR.ROCR_VISIBLE_DEVICES=GPU-fc2143878bea4591 ctest --test-dir <build> -L '^hrx$' --no-tests=error --parallel 2 --verbose: all four suites pass on gfx1100 RX 7900 XTX. Buffer 5/5, backend 106/106, Loom JIT 6/6, operations 334/334; 451 cases, zero failures.Llama-3.2-1B-Instruct-UD-Q4_K_XL.gguf:llama-bench -ngl 99 -dev HRX0 -p 128 -n 32 -r 1completes prefill/decode. Greedyllama-cligeneration on HRX0 answers the arithmetic prompt with "Two plus two equals four."git diff --checkpasses; only the minimum-commit file changes.As documented in the backend README, this minimum does not guarantee compatibility with future breaking HRX revisions.
AI usage: Codex audited the history, made the change, ran validation, and prepared this PR under explicit user direction.