Repository navigation
Adapt HRX kernel corpus to typed vector splats - #169
Open
AaronStGeorge wants to merge 1 commit into
Open
AaronStGeorge wants to merge 1 commit into
AaronStGeorge wants to merge 1 commit into
Conversation
Loom rejects the kernel corpus because vector.constant was removed. Use vector.splati and vector.splatf and require the introducing HRX merge commit because literal payloads now have separate integer and floating APIs. Relevant hrx PR: ROCm/hrx-system#2464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes required to bump
hrx-graph-develop-v2up to hrx-system: ROCm/hrx-system@893fddd.Breaking changes
Testing
Tested in
ggml-staging-automationCI with llama.cpp07f4a2da6f0band hrx-system893fddd79f.