Repository navigation
feat(messaging): recognise ANSRVR's relayed group messages and notices - #344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281
AnsrvrMessagerecognises ANSRVR's group traffic in a received message. Both kinds readN:GROUP text; who sent it tells them apart:APWW11,qAO) with no message ID. Gives the group, the poster and the text.N:NEDR 2 Messages SentorN:C4FM Now Monitoring with 2 Members.No Memberships,Duplicate (retry?) request suppressed), and lower-casen:.TryParsetakes theIncomingMessagefromMessageReceived, or the sender, text and message ID. A relay gated to RF by a two-way IGate is recognised too, onceMessagingStationunwraps it. The group is kept as written.The tests use the lines captured on APRS-IS in #272 and #281. The Messaging README and the messaging design note cover it.
AprsMap can replace its
SHIM: G34recogniser (APRS-NET/AprsMap#442) with this once it ships.