Repository navigation
feat(web): a panel can open in a browser tab of its own, the selection shared between tabs (F1.24) - #392
Merged
Conversation
gx1400
force-pushed
the
feat/f1.24-web-pop-out
branch
from
October 26, 2026 05:27
9c40127 to
e3ecf1e
Compare
gx1400
force-pushed
the
feat/f1.24-web-pop-out
branch
from
October 26, 2026 10:18
e3ecf1e to
fe4eb89
Compare
…n shared between tabs (F1.24) In the browser, each panel's menu gets Open in a new tab, which opens the page with ?panel=<kind>: that tab shows the panel alone, filling the page, and leaves the layout to the tab it came from. Selecting a station in one tab selects it in the others, over a BroadcastChannel that stays in the browser. Each tab counts as a viewer of the gateway.
gx1400
force-pushed
the
feat/f1.24-web-pop-out
branch
from
October 26, 2026 12:43
fe4eb89 to
ab2425b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212. Stacked on #391 (two-way IGate), the top of tonight's stack. Spec written first; the decisions are proposed.
What it does (browser only; the desktop's panels already float into windows of their own)
?panel=<kind>. The browser can show it as a window to drag to another monitor.?panel=packets(any case) does the same.BroadcastChannel, which stays inside the browser and the gateway's origin, and a selection received isn't echoed back.How
PlatformServices.PopOutPanel,OpenPopOutandSelectionChannel(ISelectionChannel), set only by the browser app.ShellFactory.CreatePopOutLayout, applied byShellViewModel.ShowOnly.App.StartLayoutreturns before wiring layout persistence.MainViewModel.SelectionChannelpublishes and receives selections, andPopOutTitlenames the panel in the page title.BrowserPopOutreads the query and useswindow.openandBroadcastChannelthrough[JSImport]; the callback comes back as a marshalledAction<string>. Three small functions were added tomain.js.Decisions for review:
Tests
PopOutTests(3): Open in a new tab only where there are tabs, asking for that panel; the pop-out layout is the panel alone; the selection is shared without echoing; the pop-out's title.?panel=Packetsside by side in headless Firefox. Both started, the pop-out showed the packet list alone, and there were no console errors from the app. That run caught a real bug: the panel id was case-sensitive, so?panel=Packetsshowed the whole app. It's fixed here. The gateway and Firefox were stopped afterwards.