Repository navigation
Collapsing 4x^2-4y^2 produces unsimplified 2/2 powers #178
Description
Happypig375
Issue body actions
No description provided.
Reactions are currently unavailable
Activity
- added this to the milestone
on Aug 10, 2020 - removed this from the milestone
on Sep 7, 2020 - added a commit that references this issue
on Aug 3, 2026 Re-measured on master (7f83a82) and this is fixed.
"4*x^2 - 4*y^2".ToEntity().Factorize() => 4 * (x - y) * (x + y) "x^2 - y^2".ToEntity().Factorize() => (x - y) * (x + y)No half powers left anywhere.
What was wrong. The difference-of-squares rule halved exponents without checking they were even, so it fired again on the linear factors it had just made --
(x - y)became(x^(1/2) - y^(1/2))(x^(1/2) + y^(1/2))in effect, which is where the2/2powers in your title came from -- and nothing simplified the result afterwards. The rule now requires an even exponent, and the factored form is simplified before it is returned.Pinned by a test so it stays fixed. Full suite green, 117-problem corpus unchanged.
