Repository navigation
Let the C++ build fire again (#775) - #1015
Merged
Merged
Conversation
CPPBuild.yml's path filters read "./Sources/Wrappers/AngouriMath.CPP.*/**". A path filter is a glob matched against paths relative to the repository root, so the leading "./" matches nothing: from the commit that added the filter (f51c7e0, 2026-01-02) the workflow has run zero times, while three commits touching exactly those directories were merged -- 4eb9445, dc349c3 and f4807c4. The same defect silenced Benchmark.yml for ninety-eight PRs, which is why the comment at the top of that file exists; this is the other half of the same commit. The kernel is added to the list because the exported native library is compiled from it, so a kernel change is what can break this build; and the workflow file itself is added so that a change to these filters demonstrates itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011emtnRT6EWTrxXNtqDVK3e
Member
Author
|
Proved, by the thing itself. The description said the breakage was measured and the fix was not, and that the run appearing on this PR would be the evidence. It has: Seven months and three weeks between the second row and the first. The workflow fired because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/CPPBuild.ymlhas not run since 2026-01-02. Its path filters are:A GitHub path filter is a glob matched against paths relative to the repository root, so a leading
./matches nothing. This is the identical defect that silencedBenchmark.ymlfor ninety-eight merged PRs — same commit (f51c7e03), same date, and the story is written up at the top of that file and in #775. Only one of the two was fixed.Measured, not reasoned
Zero runs since. Meanwhile three commits touching exactly the directories it names have merged (
4eb94458,dc349c3f,f4807c46), none of them building the C++ wrapper.The fix, and two additions to the list
The
./is removed. Two paths are added, each for a reason:Sources/AngouriMath/**— the exported native library is compiled from the kernel, so a kernel change is precisely what can break this build. Filtering it out meant the workflow could only ever fire for changes that were already about C++..github/workflows/CPPBuild.yml— so that a change to these filters demonstrates itself rather than being argued about. That is the trickBenchmark.ymlused to prove its own fix, and it is why this PR will make the workflow run.What this PR does not claim
The breakage is measured; the fix is not yet. It will be the moment this is pushed, and the run appearing on this PR is the evidence — which is the whole reason the workflow file is in its own filter list.
Split out of the trimming/NativeAOT work, where it was found, because it has nothing to do with AOT and should not wait on that review.