Repository navigation
The property checker runs in CI too - #1651
Merged
Merged
Conversation
PropCheck moves into Sources/Tests/Harnesses beside the other three: Simplify, Expand and Factorize must keep the value, Differentiate must agree with a difference quotient, Integrate must differentiate back. It fails on any property that does not hold, and not on a check that did not finish. On master it runs 1355 checks with 0 failures, and a negative control (an expression that cannot parse) exits 1. The ported harnesses' comments now state their reasons without the workspace's history, and the shared commit helper drops an overload none of them calls. Part of #1256. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second part of #1256. It adds
PropCheckbeside the three harnesses #1650 moved in.PropCheckSimplify,ExpandandFactorizekeep the value,Differentiateagrees with a difference quotient,Integratedifferentiates backMeasured on master
3c1cf285: 151 expressions, 1,355 checks, 0 failures, exit 0. Negative control: with an expression that cannot parse added to the corpus, it exits 1. That was reverted before committing.Also in this PR: #1650 merged the harnesses' comments as they were written for the workspace they came from, and some of them told its history. They now state just their reasons. The shared commit helper also drops an overload none of the harnesses calls.
Still outside:
canoncheckandconfluencereport known findings, so they need a recorded baseline first.crashcheck,simpsweep,rulecheckandegraphtake minutes each.Part of #1256.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura