Skip to content

Roslyn analyzer for AM - #284

Merged
WhiteBlackGoose merged 21 commits into
masterfrom
analyzers
Nov 15, 2020
Merged

WhiteBlackGoose merged 21 commits into
masterfrom
analyzers

Conversation

@WhiteBlackGoose

@WhiteBlackGoose WhiteBlackGoose commented Nov 9, 2020 •

Copy link
Copy Markdown
Member

Started working on one (WIP)

  • Get back the vsix for debuggability

Tasks for the analyzer

  • Producing warnings/errors for static non-readonly fields without [ThreadStatic]
  • Producing warnings/errors for thread static fields which have the default initialization
  • Producing warnings/errors for private fields of records without Equals overriden
  • Producing warnings for records which are neither sealed nor abstract
  • Producing warnings for public static classes that are outside of MathS
  • Producing warnings for records which are derived of Entity but don't have ToString overriden
  • Producing warnings for thrown exceptions which don't have AngouriMathException as their parent

@WhiteBlackGoose WhiteBlackGoose linked an issue Nov 9, 2020 that may be closed by this pull request
3 of 8 tasks
@codecov-io

codecov-io commented Nov 9, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #284 (46d1648) into master (a462a52) will increase coverage by 0.03%.
The diff coverage is 66.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   75.91%   75.94%   +0.03%     
==========================================
  Files         106      107       +1     
  Lines        8737     8748      +11     
  Branches     1475     1479       +4     
==========================================
+ Hits         6633     6644      +11     
+ Misses       1618     1617       -1     
- Partials      486      487       +1     
Impacted Files Coverage Δ
AngouriMath/Core/Compilation/Compiler.cs 93.91% <0.00%> (ø)
AngouriMath/Core/Domains.Classes.cs 8.16% <ø> (ø)
AngouriMath/Core/Domains.cs 100.00% <ø> (+88.88%) ⬆️
.../Continuous/Entity.Continuous.AbsSignum.Classes.cs 88.88% <0.00%> (ø)
...nuous/Entity.Continuous.ArcTrigonometry.Classes.cs 88.88% <0.00%> (ø)
...y/Continuous/Entity.Continuous.Calculus.Classes.cs 86.11% <0.00%> (ø)
.../Entity/Continuous/Entity.Continuous.Definition.cs 56.41% <ø> (+2.56%) ⬆️
...ontinuous/Entity.Continuous.Exponential.Classes.cs 90.47% <0.00%> (ø)
.../Continuous/Entity.Continuous.Factorial.Classes.cs 90.90% <0.00%> (ø)
.../Continuous/Entity.Continuous.Operators.Classes.cs 94.28% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a462a52...46d1648. Read the comment docs.

@WhiteBlackGoose WhiteBlackGoose removed a link to an issue Nov 15, 2020
3 of 8 tasks
@WhiteBlackGoose
WhiteBlackGoose marked this pull request as ready for review November 15, 2020 18:31
@WhiteBlackGoose
WhiteBlackGoose merged commit e58b541 into master Nov 15, 2020
@WhiteBlackGoose
WhiteBlackGoose deleted the analyzers branch November 17, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants