Skip to content

Issue 619 Bug: Solving a system of equations... #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WhiteBlackGoose merged 1 commit into from
Jan 19, 2024
Merged

Issue 619 Bug: Solving a system of equations... #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AngouriMath/AngouriMath/Functions/Continuous/Solvers/EquationSolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ internal static List<List<Entity>> InSolveSystem(List<Entity> equations, ReadOnl
{
var var = vars[^1];
if (equations.Count == 1)
return equations[0].InnerSimplified.SolveEquation(var) is FiniteSet els
return equations[0].InnerSimplified.SolveEquation(var).InnerSimplified is FiniteSet els
? els.Select(sol => new List<Entity> { sol }).ToList()
: new();
var result = new List<List<Entity>>();
Expand Down
19 changes: 19 additions & 0 deletions Sources/Tests/UnitTests/Algebra/SolveTest/SolveSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,24 @@ public void EquationWithDivisionIsSolved() => AssertSystemSolvable(new Entity[]
"x2 + y",
"y - x - 3"
}, new Entity.Variable[] { "x", "y" }, 2);


[Fact]
public void SystemWithZero() => AssertSystemSolvable(new Entity[] {
"x - y - 1000",
"y - 0"
}, new Entity.Variable[] { "x", "y" }, 1);

[Fact]
public void SystemWithZero2() => AssertSystemSolvable(new Entity[] {
"y - 0",
"x - y - 1000"
}, new Entity.Variable[] { "x", "y" }, 1);

[Fact]
public void SystemWithZero3() => AssertSystemSolvable(new Entity[] {
"y - 0",
"x - y"
}, new Entity.Variable[] { "x", "y" }, 1);
}
}