Repository navigation
Conversation
najibna
reviewed
Sep 21, 2026
najibna
left a comment
najibna
left a comment
There was a problem hiding this comment.
The soft-max bump to index.html, parametrization.md.html, and uisoftmax. Aligning the nodedef default from 0.0 to 1000.0 matches the spec table.
Graphs that turn on emission_weight without setting luminance will now emit 1000 nits instead of 0 — worth a release note.
Resolve conflicts in the emission parameter tables: keep the 2000 nit emission_luminance soft max from this branch, and the [0, inf)^3 range and 'Emission color multiplier' description of emission_color from dev_1.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes as below.
Note that it seems the MaterialX file didn't have the correct
emission_luminancedefault of 1000 nits, so this PR fixes that up also.