Repository navigation
Fix 1.1.1: metal edge tint weight and thin-walled geometry flag - #300
Merged
jstone-lucasfilm merged 2 commits intoApr 15, 2026
Merged
Conversation
jstone-lucasfilm
approved these changes
Apr 15, 2026
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
This looks good to me, thanks @portsmouth!
jstone-lucasfilm
merged commit Apr 15, 2026
4f8e27a
into
AcademySoftwareFoundation:dev_1.1.1
1 check passed
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bug fixes for the 1.1.1 point release:
Metal edge tint incorrectly multiplied by specular_weight (cherry-picked from MaterialX: metal edge tint should not be multiplied by specular_weight #240): the color82 (edge tint) input on metal_bsdf and metal_bsdf_tf was routed through a multiply node that applied specular_weight. Since the whole lobe is already weighted by specular_weight, the edge tint was being double-weighted. Now connects directly to the specular_color interface input.
Connect geometry_thin_walled flag to (borrowed from Connect
geometry_thin_walledtosurfacein OpenPBR MaterialX#2759): the thin-walled geometry flag was not being passed through to the surface node in the MaterialX graph.