Repository navigation
Conversation
The snapshot gave every color recipe the neutral palette as a parameter, and a palette that is given replaces the one that a recipe is configured with, so the accent, highlight, critical, warning, success, and info recipes were snapshotted with the neutral palette (gray values for the accent fills and strokes). Only the shared recipes and those of a set need the palette that is given. The recipes of a palette are evaluated as they are used now, with the palette they are configured with. The snapshot is regenerated: the 66 recipes of the six palettes that are not neutral change in the scenarios, which now have the colors of their palettes (`color.accent.fill.readable` is `#a94802`, not `#666666`). The neutral, shared, and set recipes, the layers, the palettes, and the density are the same. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The fix is to the test and the snapshot only, so it is a patch of adaptive-ui. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 442de42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The parity snapshot test of the reference tokens (
packages/adaptive-ui/src/reference/parity.spec.ts) gave every color recipe the neutral palette as a parameter. A palette that is given replaces the one that a recipe is configured with, so the recipes of the accent, highlight, critical, warning, success, and info palettes were snapshotted with the neutral palette: the accent fills and strokes were gray values.Only the shared recipes (
color.shared.*) and the recipes of a set (color.blackOrWhite.*) need the palette that is given. The recipes of a palette are now evaluated as they are used, with the palette they are configured with, and the snapshot is regenerated.This is a test and snapshot change only, so the changeset is a patch of
@adaptive-web/adaptive-ui, and it may never be published.Issues
None. It was found while checking the parity of the color recipes for the 1.0 token library migration, which compares against this snapshot.
Reviewer Notes
default,blue,orange, andgreen, light and dark, for each layer). For examplecolor.accent.fill.readablefor the default scenario is#a94802and was#666666.adaptive-uisuite passes (828 tests).releases/0.x, which is the branch of the last 0.x release (0.14.0, [AWC] Release #319).Test Plan
npm run unit-testsinpackages/adaptive-ui. The parity test fails if the evaluated recipes differ from the snapshot, and the snapshot can be regenerated withnpm run unit-tests:update-snapshots.Checklist
General
🤖 Generated with Claude Code