Repository navigation
fix(web): show the Claude icon for Claude Subscription (OAuth) channels - #12
Merged
Merged
Conversation
Channel type 64 (Claude Subscription (OAuth)) had no entry in getChannelTypeIcon's TYPE_TO_ICON map or in CHANNEL_TYPE_CONFIGS, so both fell back to the OpenAI icon. The channel list, the channel type picker and the mutate drawer all render the logo through getChannelTypeIcon, so these OAuth channels showed the OpenAI/GPT logo. - channel-utils.ts: map 64 to 'Claude', same as Anthropic (14). - channel-type-config.ts: add a 64 entry with the Anthropic icon and the CHANNEL_TYPES name. No key/model hints: the Anthropic "sk-ant-..." key hint does not apply to OAuth credentials. - Tests: assert type 64 maps to the Claude icon and shares the Anthropic config icon. HQ-Task: T261106-05 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HQ-Task: T261106-05
Agent
Links
User request
Out of scope — refuse
fork-main, not upstream)Open gate — do not open unless all are satisfied
go buildor tests passed: yesKind
Issue facts
getChannelTypeIconhas no entry for 64 and returns the'OpenAI'fallback;getChannelTypeConfig(64)returns theicon: 'openai'fallback.Change
getChannelTypeIcon: add64: 'Claude'next to Anthropic (14).CHANNEL_TYPE_CONFIGS: add a 64 entry (id,name: CHANNEL_TYPES[64],icon: 'anthropic', same icon as 14). Hints are left out because the Anthropicsk-ant-...key hint does not apply to OAuth credentials; no caller reads hints for 64 (the drawer only readshints.baseUrlfor vLLM/SGLang).Research
Duplicate / prior art
Docs and code
getChannelTypeIcon(ChannelTypeLogoinchannel-type-badge.tsx, used bychannels-table.tsx,channel-mutate-drawer.tsx,channel-provider-picker.tsx;channels-columns.tsxcalls it directly).web/src/features/subscriptionsshows the bound account only as a text label (boundAccountLabelKey), no channel icon. Codex (57) has no entry and keeps the'OpenAI'fallback, which is the intended icon.Alternatives considered
Files
web/src/features/channels/lib/channel-utils.tsweb/src/features/channels/lib/channel-type-config.tsweb/src/features/channels/lib/__tests__/channel-type-options.test.tsBehavior
Verification
web/, bun on Windows):bun install --frozen-lockfile: 1213 packages installedbun x --package @typescript/native-preview tsgo -b: exit 0, no errorsbun x vitest run src/features/channels/lib/__tests__/channel-type-options.test.ts: 4 passed (4)bun run test: Test Files 212 passed, Tests 2532 passed (2532). A first full run had 1 failure insrc/features/task-plugins/__tests__/marketplace-install-dialog.test.tsx(expect(install).toBeEnabled()), unrelated to this change; it passed on the rerun.bun x oxlint -c .oxlintrc.json <3 changed files>: exit 0bun x oxfmt --check <3 changed files>: all files use the correct formatbun run build: exit 0getChannelTypeIcon(64) === 'Claude'(equal to 14);getChannelTypeConfig(64).icon === getChannelTypeConfig(14).icon; name isClaude Subscription (OAuth).Risks
Scope check
🤖 Generated with Claude Code