You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What: honor the strict flag in LiteLLMExceptions._load ÔÇö unknown litellm exceptions are caught with generic info by default, still raise with strict=True.
Why: any new exception type added by litellm crashed aider at startup with ValueError: ... is in litellm but not in aider's exceptions list (see #5714). Runtime code and tests already distinguish the two modes ÔÇö __init__ uses the default, test_litellm_exceptions passes strict=True ÔÇö but the flag was ignored.
How: non-strict registers unknown exceptions with ExInfo(None, None, None), matching the existing get_ex_info fallback (reported cleanly, no retry loop). Added 2 tests: lenient-by-default and strict-raises.
Checklist:
Follows CONTRIBUTING.md (pytest, no type hints, <=100 cols)
Thanks — following up on this one, since it has been open a while.
All four CI workflows on this PR are sitting in action_required and have never executed:
Ubuntu Python Tests
Windows Python Tests
Docker Build Test
pre-commit
Only license/cla has actually run, and it passes. So the "tests pass" claim in the description is currently backed by local runs only (tests/basic/test_exceptions.py, 9/9) and has never been confirmed by CI on this branch.
I am not sure what the trigger is — it looks like the fork-PR gate rather than anything specific to this change, since other external PRs on main appear to be in the same state. If someone could approve the workflow runs, or tell me the expected path for a contributor in this situation, I would appreciate it. Happy to rebase, re-split, or adjust anything if that is what is needed to get it reviewed.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: honor the
strictflag inLiteLLMExceptions._loadÔÇö unknown litellm exceptions are caught with generic info by default, still raise withstrict=True.Why: any new exception type added by litellm crashed aider at startup with
ValueError: ... is in litellm but not in aider's exceptions list(see #5714). Runtime code and tests already distinguish the two modes ÔÇö__init__uses the default,test_litellm_exceptionspassesstrict=TrueÔÇö but the flag was ignored.How: non-strict registers unknown exceptions with
ExInfo(None, None, None), matching the existingget_ex_infofallback (reported cleanly, no retry loop). Added 2 tests: lenient-by-default and strict-raises.Checklist:
tests/basic/test_exceptions.py9/9