You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Treat indented fenced markers the same as non-indented ones in find_filename when looking back for a filename.
Why
find_filename misses a valid filename when the surrounding fenced block markers have leading whitespace, so a valid multi-line edit is discarded with a missing filename error. Closes#5662.
How
Fence-continuation check now uses the stripped line, matching strip_filename behavior
Added test_find_filename_with_indented_fences regression test
Thanks — following up on this one, since it has been open a while.
All four CI workflows on this PR are sitting in action_required and have never executed:
Ubuntu Python Tests
Windows Python Tests
Docker Build Test
pre-commit
Only license/cla has actually run, and it passes. So the "tests pass" claim in the description is currently backed by local runs only (tests/basic/test_exceptions.py) and has never been confirmed by CI on this branch.
I am not sure what the trigger is — it looks like the fork-PR gate rather than anything specific to this change, since other external PRs on main appear to be in the same state. If someone could approve the workflow runs, or tell me the expected path for a contributor in this situation, I would appreciate it. Happy to rebase, re-split, or adjust anything if that is what is needed to get it reviewed.
Correction to my comment above: this PR is about find_filename, so the local run that backs the description is tests/basic/test_editblock.py (26/26), not test_exceptions.py. That was copy-paste from the other PR. The CI situation is unchanged - all four workflows still action_required and never run.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat indented fenced markers the same as non-indented ones in find_filename when looking back for a filename.
Why
find_filenamemisses a valid filename when the surrounding fenced block markers have leading whitespace, so a valid multi-line edit is discarded with a missing filename error. Closes #5662.How
Checklist