You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review #2082 for code improvements: each file source handles its own errors #2677
This is not a bug report. It is an invitation to look at #1919 and #2082 again, because each file source handles its own errors, and the copies differ. The goal is to understand the change and decide whether anything should be improved. The notes below come from a quick read of the diffs and a few runs, not from a full analysis.
A parse error is thrown inside the load callback, for JSON and JSONL alike. With alasql.promise, SELECT * FROM JSONL('bad.jsonl') throws an uncaught Could not parse JSON at line 1 and the promise never settles. Fix JSON file error handling #2513 covers JSON only.
Routing both read errors and parse errors to the query's callback in one place (in loadFile, or one wrapper all file sources use) would fix every source at once. I have not checked the other sources (TXT, CSV, XLSX, …).
Activity