You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review #2156 for code improvements: MIN and MAX accept types from a list per aggregate #2696
This is not a bug report. It is an invitation to look at #2156 again, because it adds Date to a list of types each aggregate accepts, where the cause is how values are compared. The goal is to understand the change and decide whether anything should be improved. The notes below come from a quick read of the diff and a few runs, not from a full analysis.
The concerns:
Each aggregate keeps its own list of accepted types. The generated group code (src/423groupby.js) lets MIN and MAX through for numbers, bigints and now Date; SUM and AVG turn a Date into NULL. Strings are still not on the list: SELECT MAX(d), MAX(s) FROM ? returns the date and leaves the MAX(s) column out entirely.
Activity