Pressure: Fix last smoothed pressure value - #15668
Open
matthias-kleiner wants to merge 1 commit into
Open
Conversation
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
August 7, 2026 13:50
The rolling median in makeRobustPressure was computed with a one-sided (past-only) window for the last query time(s) of each ~10-minute processing slot, because no future data existed yet in the buffer. This caused the last value(s) of each slot to lag behind any pressure trend, followed by a visible jump when the next slot started with a symmetric window. Fixed by withholding trailing query points until a 2x-timeInterval look-ahead margin of future data is available, picking them up seamlessly in the next slot. Also fixes: - CCDB objects were uploaded even for slots with no new data for that quantity; now skipped when there's nothing to store. - Pressure's CCDB end-validity now anchors on its own last data point plus a margin, instead of mLastCreationTime + generic extension
matthias-kleiner
force-pushed
the
pressurefix
branch
from
August 7, 2026 13:54
e206657 to
42d36a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rolling median in makeRobustPressure was computed with a one-sided (past-only) window for the last query time(s) of each ~10-minute processing slot, because no future data existed yet in the buffer. This caused the last value(s) of each slot to lag behind any pressure trend, followed by a visible jump when the next slot started with a symmetric window. Fixed by withholding trailing query points until a 2x-timeInterval look-ahead margin of future data is available, picking them up seamlessly in the next slot.
Also fixes: