Skip to content

[O2B-1602] Add widget for runs-overview to filter by pdpBeamType - #2205

Merged
graduta merged 16 commits into
mainfrom
feature/O2B-1602-add-pdp-beam-type-filter-front-end
Aug 5, 2026
Merged

[O2B-1602] Add widget for runs-overview to filter by pdpBeamType#2205
graduta merged 16 commits into
mainfrom
feature/O2B-1602-add-pdp-beam-type-filter-front-end

Conversation

@graduta

@graduta graduta commented Jul 31, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • runs-overview page now gives option to the user to filter by pdp beam type from a set of pre-selected options
  • the beamtype filter model expects now a provider (being beam types or PDP beam types)
  • the beamtype filter model now extends the observable pattern as it loads remote data to fill in the filter

@graduta graduta self-assigned this Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (19ab138) to head (ceac6d3).

Files with missing lines Patch % Lines
.../public/services/beamTypes/pdpBeamTypesProvider.js 0.00% 4 Missing ⚠️
...ents/Filters/LhcFillsFilter/BeamTypeFilterModel.js 0.00% 2 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 2 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   46.22%   46.23%           
=======================================
  Files        1039     1039           
  Lines       17143    17142    -1     
  Branches     3124     3124           
=======================================
  Hits         7925     7925           
+ Misses       9218     9217    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta changed the base branch from main to feature/O2B-1602-add-pdp-beam-type-filter-back-end July 31, 2026 12:28
@graduta
graduta marked this pull request as ready for review July 31, 2026 12:53
@graduta
graduta requested a review from isaachilly as a code owner July 31, 2026 12:53
@graduta
graduta force-pushed the feature/O2B-1602-add-pdp-beam-type-filter-front-end branch from 97eacb4 to 110c1b4 Compare August 3, 2026 07:21
Base automatically changed from feature/O2B-1602-add-pdp-beam-type-filter-back-end to main August 4, 2026 14:14
@graduta
graduta marked this pull request as draft August 4, 2026 14:15
@graduta
graduta force-pushed the feature/O2B-1602-add-pdp-beam-type-filter-front-end branch from 110c1b4 to aa41e4f Compare August 4, 2026 14:17
@graduta
graduta marked this pull request as ready for review August 4, 2026 14:34
Comment thread lib/public/components/Filters/LhcFillsFilter/BeamTypeFilterModel.js Outdated

@isaachilly isaachilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is out-of-scope for this ticket, but the beamType selection could be applied to the RCT lhc-period-overview page also in the future. Do you agree?

@graduta

graduta commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

It is out-of-scope for this ticket, but the beamType selection could be applied to the RCT lhc-period-overview page also in the future. Do you agree?

I agree but I have the remark that it is not beamType that RCT users are seeking. For them we display and they use pdpBeamType

@isaachilly

Copy link
Copy Markdown
Collaborator

It is out-of-scope for this ticket, but the beamType selection could be applied to the RCT lhc-period-overview page also in the future. Do you agree?

I agree but I have the remark that it is not beamType that RCT users are seeking. For them we display and they use pdpBeamType

Yes, I'm saying beamType here as in general category, like beamTypeFilterModel.

isaachilly
isaachilly previously approved these changes Aug 5, 2026
@graduta
graduta merged commit f0601ea into main Aug 5, 2026
23 of 24 checks passed
@graduta
graduta deleted the feature/O2B-1602-add-pdp-beam-type-filter-front-end branch August 5, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants