Skip to content

[PWGCF] Added safeguards for pt fractions - #17359

Merged
EmilGorm merged 3 commits into
AliceO2Group:masterfrom
MaximVirta:master
Aug 6, 2026
Merged

[PWGCF] Added safeguards for pt fractions#17359
EmilGorm merged 3 commits into
AliceO2Group:masterfrom
MaximVirta:master

Conversation

@MaximVirta

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 2607e02 at 2026-08-06 12:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:889:58: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:889:111: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c142a0d at 2026-08-06 13:17:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 61 warnings.'
Found 4 errors and 61 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/3fc4a9f83ae57147c869a431bcc3a62afc156fa4/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:70:1: error: included header utility is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1274:79: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1299:79: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1314:79: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
++ [[ 61 -gt 0 ]]
++ cat /sw/BUILD/3fc4a9f83ae57147c869a431bcc3a62afc156fa4/O2Physics-code-check/warnings.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:493:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:501:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:632:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:660:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:675:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:684:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:693:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:702:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:704:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:795:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:800:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:804:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:806:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:808:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:810:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:812:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:827:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:829:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:831:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:842:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:856:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:873:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:955:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:963:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:987:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:989:146: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:991:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1013:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1015:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1017:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1022:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1024:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1028:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1030:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1034:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1036:13: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@EmilGorm
EmilGorm merged commit 0a1577a into AliceO2Group:master Aug 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants