[PWGLF,PWGMM] Add a new task for vertex-based vdM scan analyses - #17361
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
[PWGLF,PWGMM] Please consider the following formatting changes to AliceO2Group#17361
mjkim525
marked this pull request as ready for review
August 7, 2026 03:00
Collaborator
|
Error while checking build/O2Physics/code-check for 1a963b5 at 2026-08-07 05:07: Full log here. |
jgcn
reviewed
Aug 7, 2026
jgcn
left a comment
Collaborator
There was a problem hiding this comment.
Hi
I see still some errors. Unfortunately, I am not a C++ expert so I have no concrete suggestions. Could you please have a look to see if you manage to solve at least some of them? If you do not manage, and you assure me that these are more warnings than errors, I could approve the new code. (Unless someone else in the list of people that grant approvals, and who have a lot more C++ knowledge than I, has another opinion .)
have a nice day
guillermo
jgcn
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new lumiVertex analysis task for vertex-based van der Meer scan analyses such as Length-Scale Calibration, Non-factorization effect correction.
The task is based on the existing PWGMM/Lumi/Tasks/lumi.cxx workflow and is designed to store the primary-vertex and bunch-crossing information needed for luminosity studies based on reconstructed collision vertices.