Skip to content

[PWGCF] Fix string forming issue - #17567

Merged
ktf merged 1 commit into
AliceO2Group:masterfrom
ktf:pr17567
Aug 23, 2026
Merged

[PWGCF] Fix string forming issue#17567
ktf merged 1 commit into
AliceO2Group:masterfrom
ktf:pr17567

Conversation

@ktf

@ktf ktf commented Aug 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 10 errors, ⚠️ 48 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix string forming issue [PWGCF] Fix string forming issue Aug 23, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fb8ccd8 at 2026-08-23 14:49:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 68 warnings.'
Found 14 errors and 68 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/ff5f5a397ae1b368280fec2eaba6da525b834846/O2Physics-code-check/errors.txt
PWGCF/FemtoDream/Core/femtoDreamObjectSelection.h:45:7: error: constructor does not initialize these fields: mHistogramRegistry, mQAHistogramRegistry [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:45:7: error: constructor does not initialize these fields: mHistogramRegistry [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:60:30: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:60:54: error: the parameter 'tempFitVarAxisTitle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:102:31: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:210:28: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:210:75: error: the parameter #2 is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:315:320: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:321:167: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:405:11: error: variable 'momentum' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:76:3: error: constructor does not initialize these fields: nITSclsMin, nITSclsIbMin [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:221:12: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamV0Selection.h:615:9: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamV0Selection.h:630:9: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
++ [[ 68 -gt 0 ]]
++ cat /sw/BUILD/ff5f5a397ae1b368280fec2eaba6da525b834846/O2Physics-code-check/warnings.txt
PWGCF/FemtoDream/Core/femtoDreamObjectSelection.h:34:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:62:32: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:105:32: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:213:32: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:843:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:41:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:196:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:196:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:235:8: warning: use default member initializer for 'nRejectNotPropagatedTracks' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:236:7: warning: use default member initializer for 'nPtMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:237:7: warning: use default member initializer for 'nPtMaxSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:238:7: warning: use default member initializer for 'nEtaSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:239:7: warning: use default member initializer for 'nTPCnMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:240:7: warning: use default member initializer for 'nTPCfMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:241:7: warning: use default member initializer for 'nTPCcMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:242:7: warning: use default member initializer for 'nTPCsMaxSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:243:7: warning: use default member initializer for 'nITScMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:244:7: warning: use default member initializer for 'nITScIbMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:245:7: warning: use default member initializer for 'nDCAxyMaxSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:246:7: warning: use default member initializer for 'nDCAzMaxSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:247:7: warning: use default member initializer for 'nDCAMinSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:248:7: warning: use default member initializer for 'nPIDnSigmaSel' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:249:9: warning: use default member initializer for 'pTMin' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:250:9: warning: use default member initializer for 'pTMax' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:251:9: warning: use default member initializer for 'etaMax' [modernize-use-default-member-init]
PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h:252:9: warning: use default member initializer for 'nClsMin' [modernize-use-default-member-init]
[0 more errors; see full log]

Full log here.

@ktf
ktf merged commit 451eee9 into AliceO2Group:master Aug 23, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants