Update nuget depencencies (back port of #1218) - #1221
Merged
Merged
Conversation
* Update nuget depencencies Notable changes * Changed from Microsoft.CodeAnalysis.Workspaces to Microsoft.CodeAnalysis.CSharp, in Inernal.Analyzers because of a compiller warning see: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md * Updated SDK reference in global.json * Updated Applicationinsights package and removed the test from #594 * Updated to released version of HybridCache and remove #pragma waring disable for preview * Used [CallerFilePath] intead of assemly location to find test data folder.
ivarne
added
dependency
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR back-ports dependency updates and improvements from a previous PR (#1218) to address compiler warnings and update NuGet packages.
- Removed an outdated test for keyed services telemetry diagnostics.
- Updated test data location resolution by using [CallerFilePath] instead of assembly location.
- Removed obsolete pragma warnings for HybridCache in the service collection extensions.
Reviewed Changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Altinn.App.Api.Tests/Telemetry/TelemetryConfigurationTests.cs | Removed deprecated test verifying keyed services error diagnostics. |
| test/Altinn.App.Api.Tests/Data/TestData.cs | Updated retrieval of test data directory using CallerFilePath. |
| src/Altinn.App.Core/Extensions/ServiceCollectionExtensions.cs | Removed pragma warning disabling for EXTEXP0018 in favor of released HybridCache. |
Files not reviewed (8)
- global.json: Language not supported
- src/Altinn.App.Api/Altinn.App.Api.csproj: Language not supported
- src/Altinn.App.Core/Altinn.App.Core.csproj: Language not supported
- test/Altinn.App.Api.Tests/Altinn.App.Api.Tests.csproj: Language not supported
- test/Altinn.App.Api.Tests/OpenApi/OpenApiSpecChangeDetection.SaveJsonSwagger.verified.txt: Language not supported
- test/Altinn.App.Api.Tests/OpenApi/swagger.json: Language not supported
- test/Altinn.App.Common.Tests/Altinn.App.Common.Tests.csproj: Language not supported
- test/Altinn.App.Core.Tests/Altinn.App.Core.Tests.csproj: Language not supported
|
martinothamar
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes from #1218