Repository navigation
feat(template-generator): upgrade native expo templates to sdk 57 #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 2 additions & 8 deletions
10
packages/template-generator/templates/extras/pnpm-workspace.yaml.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: AmanVarshney01/create-better-t-stack
Length of output: 25978
🏁 Script executed:
Repository: AmanVarshney01/create-better-t-stack
Length of output: 11000
🏁 Script executed:
Repository: AmanVarshney01/create-better-t-stack
Length of output: 50393
🏁 Script executed:
Repository: AmanVarshney01/create-better-t-stack
Length of output: 5566
🌐 Web query:
npm package manifests for react-native-reanimated react-native-worklets react-native-gesture-handler react-native-nitro-modules expo-dev-client install postinstall scripts💡 Result:
In the React Native ecosystem, the use of
postinstallscripts within package manifests is generally discouraged due to potential security risks and interference with package manager processes [1]. Below is a breakdown of the status for the requested packages: 1. react-native-reanimated: Does not include apostinstallscript [1]. Older versions historically required workarounds likejetifierinpostinstall[2], but modern configurations rely on standard build processes [3]. 2. react-native-worklets: Generally does not rely onpostinstallscripts for end-user installation [4][5]. 3. react-native-gesture-handler: Does not include apostinstallscript [6]. As with other libraries, historical needs forjetifierinpostinstallare no longer applicable to modern React Native versions [7]. 4. react-native-nitro-modules: Has been observed containing apostinstallscript (e.g.,"postinstall": "bun build || exit 0") in some versions, which has occasionally caused issues in specific environments [8]. Users have sometimes employedpatch-packageto override or nullify this script in their localnode_moduleswhen conflicts arise [8]. 5. expo-dev-client: Does not use apostinstallscript [9][10]. Configuration is managed via the Expo CLI (npx expo install) and standard native build processes likepod install[9][10]. Note: While these libraries generally avoidpostinstallscripts, projects often usepatch-packagein their ownpackage.jsonpostinstallscripts to apply hotfixes to dependencies when necessary [11][12][13][14][15]. Additionally, Expo provides dedicated build lifecycle hooks (e.g.,eas-build-post-install) for managing tasks during CI/CD builds, which should be used instead of standardpostinstallscripts for environment-specific build steps [16].Citations:
scriptsdirectory to root software-mansion/react-native-gesture-handler#3506🌐 Web query:
react-native-nitro-modules 0.36.1 npm registry package.json scripts postinstall💡 Result:
In the react-native-nitro-modules package, the postinstall script historically includes the command "bun build || exit 0;" [1][2][3]. This script is designed to trigger a build process using the Bun runtime upon package installation [1]. If you encounter issues with this script during installation—such as environments where Bun is not available or where the script fails—it has been noted in community discussions that some users mitigate this by patching the package.json to replace the command with a simple "exit 0;" [1]. The package is a core library for Nitro Modules, providing statically compiled bindings for React Native [4][5][6]. It is maintained as part of a monorepo, and its package.json scripts are integral to managing the library's build and versioning lifecycle [1][7].
Citations:
Include
native-unistylesin theallowBuildsgate.native-unistylespulls inreact-native-nitro-modules, which has apostinstallscript (bun build || exit 0), so a pure native pnpm workspace can lose the whole allowlist and get blocked on install.