Repository navigation
feat(template-generator): upgrade Next.js to 16.3 - #1141
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cf89822 to
c1f558e
Compare
c1f558e to
e1810dc
Compare
WalkthroughThe PR upgrades Next.js to 16.3.0 in the web app and generated templates. It adds generated Next.js guidance, removes the Turbopack filesystem cache setting, and adds Bun type definitions. ChangesNext.js 16.3 upgrade
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f05b085e-3df5-4854-bca6-518f5153bd9f
⛔ Files ignored due to path filters (2)
bun.lockis excluded by!**/*.lockpackages/template-generator/src/templates.generated.tsis excluded by!**/*.generated.*
📒 Files selected for processing (8)
apps/cli/test/frontend.test.tsapps/web/AGENTS.mdapps/web/next.config.tsapps/web/package.jsonapps/web/tsconfig.jsonpackages/template-generator/src/utils/add-deps.tspackages/template-generator/templates/frontend/react/next/AGENTS.md.hbspackages/template-generator/templates/frontend/react/next/package.json.hbs
💤 Files with no reviewable changes (1)
- apps/web/next.config.ts
| expect(agentRules).toContain("<!-- BEGIN:nextjs-agent-rules -->"); | ||
| expect(agentRules).toContain("node_modules/next/dist/docs/"); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Assert the generated-file instruction.
The test passes if AGENTS.md loses the instruction that next dev regenerates this block. Assert node_modules/next/dist/server/lib/generate-agent-files.js so the baseline covers that required guidance.
Based on learnings: next dev regenerates this block, and node_modules/next/dist/server/lib/generate-agent-files.js is the canonical source.
Proposed test update
expect(agentRules).toContain("<!-- BEGIN:nextjs-agent-rules -->");
expect(agentRules).toContain("node_modules/next/dist/docs/");
+ expect(agentRules).toContain(
+ "node_modules/next/dist/server/lib/generate-agent-files.js",
+ );📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| expect(agentRules).toContain("<!-- BEGIN:nextjs-agent-rules -->"); | |
| expect(agentRules).toContain("node_modules/next/dist/docs/"); | |
| expect(agentRules).toContain("<!-- BEGIN:nextjs-agent-rules -->"); | |
| expect(agentRules).toContain("node_modules/next/dist/docs/"); | |
| expect(agentRules).toContain( | |
| "node_modules/next/dist/server/lib/generate-agent-files.js", | |
| ); |
Source: Learnings
e1810dc to
3166707
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
eslint-config-next, the lockfile, and generated dependency metadata with Next.js 16.3Verification
bun run test:complete— full monorepo check and build, 867 tests across 40 files, 0 failures, and the complete 282-case template smoke matrixgit diff --checkDocs checked
node_modules/next/dist/docs/Summary by CodeRabbit
New Features
Updates
Developer Experience