Repository navigation
fix(templates): preserve Varlock ENV access and scope deployment URLs - #1238
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. WalkthroughChangesEnvironment and URL generation
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The generated ENV migration and deployment-aware URL selection have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (10 skipped: 10 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated clients imported Varlock as
ENV as env, preventing the Vite integration from replacingENV.KEYaccesses and causing the browser to crash when reading the server URL. Preserve the canonicalENVimport and accesses across web/native auth, RPC, provider, and AI templates; remove the generator rewrite that introduced the alias and match the Cloudflare public-env export.Use explicit Handlebars conditions and JavaScript URL expressions in the templates, without custom URL helpers or
SafeStringcode generation. Only generate URL resolvers for combined Vercel or Docker deployments. Other clients use their configured public server URL directly; Vercel-specific environment handling is emitted only for Vercel. Keep Docker’s internal SSR server URL. Remove the unnecessarycreateConfiguredAuthalias from singleton services, retaining it where a localcreateAuthfactory requires a distinct name.Verification:
bun run check, CLI build/publint, CLI source/test typechecks, generator typecheck.~/dev/test: install, schema push, typecheck, and production build passed.Varlock references: Vite integration and monorepo guide.
Summary by CodeRabbit
Bug Fixes
Tests