Repository navigation
feat(cli): add PlanetScale and OpenTUI skill sources - #896
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdded two new skill sources (planetscale/database-skills and msmps/opentui-skill) to the skills setup configuration. Implemented automatic recommendation logic for these sources based on database and addon configuration, and extended curated skills mapping to support them. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/cli/src/helpers/addons/skills-setup.ts (1)
216-230: Redundant guard at line 217 can be removed.The
if (config.dbSetup !== "planetscale") return [];branch is unreachable:getCuratedSkillNamesForSourceKeyis only invoked for source keys present inrecommendedSourceKeys, and"planetscale/database-skills"is only pushed there whendbSetup === "planetscale". No analogous guard exists on the equivalent"neondatabase/agent-skills"or"supabase/agent-skills"entries.The four skill names (
"postgres","neki","mysql","vitess") are all confirmed correct from the officialplanetscale/database-skillssite, which lists these exact four skills — with "neki" being PlanetScale's sharded Postgres product.♻️ Suggested simplification
- "planetscale/database-skills": (config) => { - if (config.dbSetup !== "planetscale") { - return []; - } - - if (config.database === "postgres") { + "planetscale/database-skills": (config) => { + if (config.database === "postgres") { return ["postgres", "neki"]; } if (config.database === "mysql") { return ["mysql", "vitess"]; } return []; },
Summary
Verification
Summary by CodeRabbit