add bar corner roundness attribute - #2
Open
Andrucis wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility to adjust roundness of trace bar corners.
Each corners roundness can be adjusted individually.
Value passed represents percentage of desirable roundness.
"cornerroundness": { "bottomleft": 0.3, "bottomright": 0, "topleft": 0.3, "topright": 0 }
This is implemented by taking calculated vector values in bar\plot.js file and adjusting them when generating svg path description attribute.
Round corners are drawn with absolute elliptical arc curve command A.
Arc radius is calculated by taking the smallest edge width of all bars and dividing it by two and then applying desired roundness percentage value.
All four possible vector drawing directions are handled.