Skip to content

Expose Simmy APIs - #1784

Merged
martincostello merged 3 commits into
App-vNext:mainfrom
vany0114:simmy-expose-apis
Nov 16, 2023
Merged

martincostello merged 3 commits into
App-vNext:mainfrom
vany0114:simmy-expose-apis

Conversation

@vany0114

@vany0114 vany0114 commented Nov 11, 2023 •

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Exposes Simmy's API's so that we can start getting the release and docs ready.

Details on the issue fix or feature implementation

It just makes public the pipelines, etc.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov

codecov Bot commented Nov 11, 2023 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2697912) 84.59% compared to head (928d250) 84.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1784   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         308      308           
  Lines        6802     6802           
  Branches     1049     1049           
=======================================
  Hits         5754     5754           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.59% <ø> (ø)
macos 84.59% <ø> (ø)
windows 84.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello

Copy link
Copy Markdown
Member

I suggest that we leave merging this and any other public-facing Simmy-related changes until Wednesday so we can get out the .NET 8.0 changes on Tuesday once .NET 8.0 ships as Polly 8.2, then Simmy can follow as 8.3.

@martincostello martincostello added this to the v8.3.0 milestone Nov 14, 2023
@martintmk martintmk mentioned this pull request Nov 14, 2023
4 tasks
@vany0114

Copy link
Copy Markdown
Contributor Author

@martincostello @martintmk can we merge this guy?

@martintmk

Copy link
Copy Markdown
Contributor

@martincostello @martintmk can we merge this guy?

Yup, 8.2.0 is already out.

# Conflicts:
#	src/Polly.Core/PublicAPI.Unshipped.txt
@martincostello
martincostello merged commit 4f9380e into App-vNext:main Nov 16, 2023
@martincostello

Copy link
Copy Markdown
Member

What are the tasks left for releasing the Simmy changes? I imagine at a minimum we need to update the documentation?

@vany0114

Copy link
Copy Markdown
Contributor Author

What are the tasks left for releasing the Simmy changes? I imagine at a minimum we need to update the documentation?

Yep, that will be my next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants