Skip to content

Add unit to execution time in telemetry events - #2069

Merged
martincostello merged 4 commits into
App-vNext:mainfrom
peter-csala:Fix-execution-attempt-message-format
Apr 22, 2024
Merged

martincostello merged 4 commits into
App-vNext:mainfrom
peter-csala:Fix-execution-attempt-message-format

Conversation

@peter-csala

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Follow up of #2060

  • Execution time did not have an unit in the reported telemetry events

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@peter-csala

Copy link
Copy Markdown
Contributor Author

I've just realized that the Chaos strategies are also reporting telemetry events.

  • Do we want to extend those pages as well with Telemetry section?
  • Do we want to list those events on the Telemetry page's event names section?

Comment thread src/Polly.Extensions/Telemetry/Log.cs
@codecov

codecov Bot commented Apr 22, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (1393901) to head (00ea17c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2069   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files         312      312           
  Lines        7114     7114           
  Branches     1054     1054           
=======================================
  Hits         5954     5954           
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.69% <ø> (ø)
macos ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello

Copy link
Copy Markdown
Member
  • Do we want to extend those pages as well with Telemetry section?

I would say yes to both so there's parity in the documentation.

@peter-csala

Copy link
Copy Markdown
Contributor Author
  • Do we want to extend those pages as well with Telemetry section?

I would say yes to both so there's parity in the documentation.

Okay, I'll do that in a separate PR.

@martincostello martincostello added this to the v8.4.0 milestone Apr 22, 2024
@martincostello
martincostello merged commit b89ce23 into App-vNext:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants